From: Arnd Bergmann <arnd@arndb.de>
To: Ike Panhc <ike.pan@canonical.com>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>
Cc: "Arnd Bergmann" <arnd@arndb.de>,
"Michał Kępień" <kernel@kempniu.pl>,
"Brian Masney" <masneyb@onstation.org>,
"Ritesh Raj Sarraf" <rrs@debian.org>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] platform/x86: ideapad-laptop: hide unused 'touchpad_store'
Date: Mon, 22 May 2017 15:07:03 +0200 [thread overview]
Message-ID: <20170522130709.242445-1-arnd@arndb.de> (raw)
A readonly sysfs property must not have a 'store' function:
drivers/platform/x86/ideapad-laptop.c:438:16: error: 'touchpad_store' defined but not used [-Werror=unused-function]
We can either comment it out or remove the function entirely,
without a good reason one or or another I picked the second option.
Fixes: 7f363145992c ("platform/x86: ideapad-laptop: Switch touchpad attribute to be RO")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/platform/x86/ideapad-laptop.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
index f7a4608cc60b..c4c7ae3179c0 100644
--- a/drivers/platform/x86/ideapad-laptop.c
+++ b/drivers/platform/x86/ideapad-laptop.c
@@ -435,6 +435,8 @@ static ssize_t touchpad_show(struct device *dev,
return sprintf(buf, "%lu\n", result);
}
+#if 0
+/* Switch to RO for now: It might be revisited in the future */
static ssize_t touchpad_store(struct device *dev,
struct device_attribute *attr,
const char *buf, size_t count)
@@ -453,7 +455,7 @@ static ssize_t touchpad_store(struct device *dev,
return count;
}
-/* Switch to RO for now: It might be revisited in the future */
+#endif
static DEVICE_ATTR_RO(touchpad);
static struct attribute *ideapad_attributes[] = {
--
2.9.0
next reply other threads:[~2017-05-22 13:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 13:07 Arnd Bergmann [this message]
2017-05-22 17:02 ` Andy Shevchenko
2017-05-22 20:36 ` Arnd Bergmann
2017-05-23 16:37 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170522130709.242445-1-arnd@arndb.de \
--to=arnd@arndb.de \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=ike.pan@canonical.com \
--cc=kernel@kempniu.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=masneyb@onstation.org \
--cc=mika.westerberg@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rrs@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®