mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: linux-kernel@vger.kernel.org
Cc: acme@kernel.org, alexander.shishkin@linux.intel.com,
	ganapatrao.kulkarni@cavium.com
Subject: Re: [PATCH 0/2] perf stat: fix segfault when closing events
Date: Tue, 23 May 2017 11:04:47 +0100	[thread overview]
Message-ID: <20170523100446.GB14542@leverpostej> (raw)
In-Reply-To: <1493380030-4683-1-git-send-email-mark.rutland@arm.com>

Hi,

Does anyone have any comments on these?

I'm happy to rebase/resend if necessary.

I'd very much like to see this fixed.

Thanks,
Mark.

On Fri, Apr 28, 2017 at 12:47:08PM +0100, Mark Rutland wrote:
> Hi,
> 
> These patches fix a segfault seen in some cases when perf stat is exiting.
> 
> We don't balance opening/closing of events in all cases, and go out-of-bounds
> when we close events. Full details in the patch 2 commit message.
> 
> Thanks,
> Mark.
> 
> Mark Rutland (2):
>   perf evsel: add per{cpu,thread} close helpers
>   perf stat: balance opening/closing of events
> 
>  tools/perf/builtin-stat.c | 24 +++++++++++++++++++++++-
>  tools/perf/util/evsel.c   | 26 ++++++++++++++++++++------
>  tools/perf/util/evsel.h   |  4 ++++
>  3 files changed, 47 insertions(+), 7 deletions(-)
> 
> -- 
> 1.9.1
> 

  parent reply	other threads:[~2017-05-23 10:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-28 11:47 Mark Rutland
2017-04-28 11:47 ` [PATCH 1/2] perf evsel: add per{cpu,thread} close helpers Mark Rutland
2017-04-28 11:47 ` [PATCH 2/2] perf stat: balance opening/closing of events Mark Rutland
2017-05-23 10:04 ` Mark Rutland [this message]
2017-05-23 15:14   ` [PATCH 0/2] perf stat: fix segfault when closing events Ganapatrao Kulkarni
2017-06-09  4:33     ` Ganapatrao Kulkarni
2017-07-12  7:16       ` Ganapatrao Kulkarni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170523100446.GB14542@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=ganapatrao.kulkarni@cavium.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®