From: David Miller <davem@davemloft.net>
To: glider@google.com
Cc: dvyukov@google.com, kcc@google.com, edumazet@google.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net: rtnetlink: bail out from rtnl_fdb_dump() on parse error
Date: Wed, 24 May 2017 15:32:24 -0400 (EDT) [thread overview]
Message-ID: <20170524.153224.1230164587077679673.davem@davemloft.net> (raw)
In-Reply-To: <20170523112028.132630-1-glider@google.com>
From: Alexander Potapenko <glider@google.com>
Date: Tue, 23 May 2017 13:20:28 +0200
> rtnl_fdb_dump() failed to check the result of nlmsg_parse(), which led
> to contents of |ifm| being uninitialized because nlh->nlmsglen was too
> small to accommodate |ifm|. The uninitialized data may affect some
> branches and result in unwanted effects, although kernel data doesn't
> seem to leak to the userspace directly.
>
> The bug has been detected with KMSAN and syzkaller.
>
> Signed-off-by: Alexander Potapenko <glider@google.com>
Applied, thanks.
next prev parent reply other threads:[~2017-05-24 19:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 11:20 Alexander Potapenko
2017-05-24 19:29 ` Greg Rose
2017-05-24 19:32 ` David Miller [this message]
2017-05-31 8:56 ` Alexander Potapenko
2017-05-31 15:10 ` David Miller
2017-05-31 15:24 ` Alexander Potapenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170524.153224.1230164587077679673.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dvyukov@google.com \
--cc=edumazet@google.com \
--cc=glider@google.com \
--cc=kcc@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®