From: Alan Cox <gnomes@lxorguk.ukuu.org.uk>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Zha Qipeng <qipeng.zha@intel.com>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>
Subject: Re: [PATCH] platform/x86: intel_pmc_ipc: Delete unused function ipc_data_readb()
Date: Wed, 24 May 2017 14:39:32 +0100 [thread overview]
Message-ID: <20170524143932.11593845@alans-desktop> (raw)
In-Reply-To: <20170523205539.71450-1-mka@chromium.org>
On Tue, 23 May 2017 13:55:39 -0700
Matthias Kaehlcke <mka@chromium.org> wrote:
> The function was added by commit 0a8b83530b6f ("intel_pmc_ipc: Add Intel
> Apollo Lake PMC IPC driver") in 2015 and hasn't been used since then.
> Removing it fixes the following warning when building with clang:
>
> drivers/platform/x86/intel_pmc_ipc.c:189:18: error: unused function
> 'ipc_data_readb' [-Werror,-Wunused-function]
It is however also part of the API and a consistent sensible function to
have present should it be needed. As it's static it's eliminated
correctly by gcc.
I'm all for eliminating unused functions but in this case I have to wonder
Alan
next prev parent reply other threads:[~2017-05-24 13:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 20:55 Matthias Kaehlcke
2017-05-24 13:39 ` Alan Cox [this message]
2017-05-24 15:39 ` Doug Anderson
2017-05-25 13:26 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170524143932.11593845@alans-desktop \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=andy@infradead.org \
--cc=dianders@chromium.org \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=qipeng.zha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®