From: David Miller <davem@davemloft.net>
To: petedaws@gmail.com
Cc: kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org,
kaber@trash.net, stephen@networkplumber.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] ip6_tunnel, ip6_gre: fix setting of DSCP on encapsulated packets
Date: Thu, 25 May 2017 16:33:29 -0400 (EDT) [thread overview]
Message-ID: <20170525.163329.1506857538759050908.davem@davemloft.net> (raw)
In-Reply-To: <20170526060842.4bd21054@udesktop>
From: Peter Dawson <petedaws@gmail.com>
Date: Fri, 26 May 2017 06:08:42 +1000
> On Thu, 25 May 2017 15:49:14 -0400 (EDT)
> David Miller <davem@davemloft.net> wrote:
>
>> Still not correct, you need to use a "Fixes: " tag of the form:
>>
>> Fixes: 90427ef5d2a4 ("ipv6: fix flow labels when the traffic class is non-0")
>>
>> And it must appear of the first line of tags, before signoffs and acks,
>> with no empty lines in between.
>
> Here is my proposed commit message in full. Note that
> the "Fixes" line extends to 78 chars. Is this OK?
Yes, that looks perfect.
next prev parent reply other threads:[~2017-05-25 20:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 4:36 Peter Dawson
2017-05-25 16:11 ` David Miller
2017-05-25 19:46 ` Peter Dawson
2017-05-25 19:49 ` David Miller
2017-05-25 20:08 ` Peter Dawson
2017-05-25 20:33 ` David Miller [this message]
2017-05-25 20:35 ` [PATCH net,v2] " Peter Dawson
2017-05-26 18:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170525.163329.1506857538759050908.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=petedaws@gmail.com \
--cc=stephen@networkplumber.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®