From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Nicolas Iooss <nicolas.iooss_linux@m4x.org>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] printk: add __printf attributes to internal functions
Date: Thu, 25 May 2017 21:02:36 +0900 [thread overview]
Message-ID: <20170525120236.GD386@jagdpanzerIV.localdomain> (raw)
In-Reply-To: <20170525112902.GG12489@pathway.suse.cz>
On (05/25/17 13:29), Petr Mladek wrote:
> On Wed 2017-05-24 07:49:50, Nicolas Iooss wrote:
> > When compiling with -Wsuggest-attribute=format, gcc complains that some
> > functions in kernel/printk/printk_safe.c transmit their argument to
> > printf-like functions without having a printf attribute. Silence these
> > warnings by adding relevant __printf attributes.
> >
> > Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
> > Acked-by: Petr Mladek <pmladek@suse.com>
> > ---
> > v2: add __printf attribute to the definition of vprintk_nmi() which is
> > used when CONFIG_PRINTK_NMI is not defined.
>
> Sergey, I believe that that your Reviewed-by is still valid even after
> this small update. Is that true, please?
sure. sorry about that!
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
-ss
prev parent reply other threads:[~2017-05-25 12:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-20 9:18 [PATCH " Nicolas Iooss
2017-05-22 2:48 ` Sergey Senozhatsky
2017-05-22 15:22 ` Petr Mladek
2017-05-24 5:49 ` [PATCH v2 " Nicolas Iooss
2017-05-25 11:29 ` Petr Mladek
2017-05-25 12:02 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170525120236.GD386@jagdpanzerIV.localdomain \
--to=sergey.senozhatsky.work@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.iooss_linux@m4x.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®