* [PATCH] Lower the log level of debug outputs
@ 2017-05-30 6:54 Hirokazu Honda
2017-05-30 7:39 ` Alexandre Courbot
0 siblings, 1 reply; 2+ messages in thread
From: Hirokazu Honda @ 2017-05-30 6:54 UTC (permalink / raw)
To: Pawel Osciak, Marek Szyprowski, Mauro Carvalho Chehab
Cc: linux-media, linux-kernel, Hirokazu Honda
Some debug output whose log level is set 1 flooded the log.
Their log level is lowered to find the important log easily.
Signed-off-by: Hirokazu Honda <hiroh@chromium.org>
---
drivers/media/v4l2-core/videobuf2-core.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c
index 94afbbf92807..25257f92bbcf 100644
--- a/drivers/media/v4l2-core/videobuf2-core.c
+++ b/drivers/media/v4l2-core/videobuf2-core.c
@@ -1139,7 +1139,7 @@ static int __qbuf_dmabuf(struct vb2_buffer *vb, const void *pb)
continue;
}
- dprintk(1, "buffer for plane %d changed\n", plane);
+ dprintk(3, "buffer for plane %d changed\n", plane);
if (!reacquired) {
reacquired = true;
@@ -1294,7 +1294,7 @@ int vb2_core_prepare_buf(struct vb2_queue *q, unsigned int index, void *pb)
/* Fill buffer information for the userspace */
call_void_bufop(q, fill_user_buffer, vb, pb);
- dprintk(1, "prepare of buffer %d succeeded\n", vb->index);
+ dprintk(2, "prepare of buffer %d succeeded\n", vb->index);
return ret;
}
@@ -1424,7 +1424,7 @@ int vb2_core_qbuf(struct vb2_queue *q, unsigned int index, void *pb)
return ret;
}
- dprintk(1, "qbuf of buffer %d succeeded\n", vb->index);
+ dprintk(2, "qbuf of buffer %d succeeded\n", vb->index);
return 0;
}
EXPORT_SYMBOL_GPL(vb2_core_qbuf);
@@ -1472,7 +1472,7 @@ static int __vb2_wait_for_done_vb(struct vb2_queue *q, int nonblocking)
}
if (nonblocking) {
- dprintk(1, "nonblocking and no buffers to dequeue, will not wait\n");
+ dprintk(3, "nonblocking and no buffers to dequeue, will not wait\n");
return -EAGAIN;
}
@@ -1619,7 +1619,7 @@ int vb2_core_dqbuf(struct vb2_queue *q, unsigned int *pindex, void *pb,
/* go back to dequeued state */
__vb2_dqbuf(vb);
- dprintk(1, "dqbuf of buffer %d, with state %d\n",
+ dprintk(2, "dqbuf of buffer %d, with state %d\n",
vb->index, vb->state);
return 0;
--
2.13.0.219.gdb65acc882-goog
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] Lower the log level of debug outputs
2017-05-30 6:54 [PATCH] Lower the log level of debug outputs Hirokazu Honda
@ 2017-05-30 7:39 ` Alexandre Courbot
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Courbot @ 2017-05-30 7:39 UTC (permalink / raw)
To: Hirokazu Honda
Cc: Pawel Osciak, Marek Szyprowski, Mauro Carvalho Chehab,
linux-media, linux-kernel
On Tue, May 30, 2017 at 3:54 PM, Hirokazu Honda <hiroh@chromium.org> wrote:
> Some debug output whose log level is set 1 flooded the log.
> Their log level is lowered to find the important log easily.
>
> Signed-off-by: Hirokazu Honda <hiroh@chromium.org>
Your patch title should specify the subsystem of your patch. Something
like "[media] vb2: core: Lower the log level of debug outputs"
Otherwise,
Acked-by: Alexandre Courbot <acourbot@chromium.org>
> ---
> drivers/media/v4l2-core/videobuf2-core.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c
> index 94afbbf92807..25257f92bbcf 100644
> --- a/drivers/media/v4l2-core/videobuf2-core.c
> +++ b/drivers/media/v4l2-core/videobuf2-core.c
> @@ -1139,7 +1139,7 @@ static int __qbuf_dmabuf(struct vb2_buffer *vb, const void *pb)
> continue;
> }
>
> - dprintk(1, "buffer for plane %d changed\n", plane);
> + dprintk(3, "buffer for plane %d changed\n", plane);
>
> if (!reacquired) {
> reacquired = true;
> @@ -1294,7 +1294,7 @@ int vb2_core_prepare_buf(struct vb2_queue *q, unsigned int index, void *pb)
> /* Fill buffer information for the userspace */
> call_void_bufop(q, fill_user_buffer, vb, pb);
>
> - dprintk(1, "prepare of buffer %d succeeded\n", vb->index);
> + dprintk(2, "prepare of buffer %d succeeded\n", vb->index);
>
> return ret;
> }
> @@ -1424,7 +1424,7 @@ int vb2_core_qbuf(struct vb2_queue *q, unsigned int index, void *pb)
> return ret;
> }
>
> - dprintk(1, "qbuf of buffer %d succeeded\n", vb->index);
> + dprintk(2, "qbuf of buffer %d succeeded\n", vb->index);
> return 0;
> }
> EXPORT_SYMBOL_GPL(vb2_core_qbuf);
> @@ -1472,7 +1472,7 @@ static int __vb2_wait_for_done_vb(struct vb2_queue *q, int nonblocking)
> }
>
> if (nonblocking) {
> - dprintk(1, "nonblocking and no buffers to dequeue, will not wait\n");
> + dprintk(3, "nonblocking and no buffers to dequeue, will not wait\n");
> return -EAGAIN;
> }
>
> @@ -1619,7 +1619,7 @@ int vb2_core_dqbuf(struct vb2_queue *q, unsigned int *pindex, void *pb,
> /* go back to dequeued state */
> __vb2_dqbuf(vb);
>
> - dprintk(1, "dqbuf of buffer %d, with state %d\n",
> + dprintk(2, "dqbuf of buffer %d, with state %d\n",
> vb->index, vb->state);
>
> return 0;
> --
> 2.13.0.219.gdb65acc882-goog
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-30 7:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-30 6:54 [PATCH] Lower the log level of debug outputs Hirokazu Honda
2017-05-30 7:39 ` Alexandre Courbot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®