From: Arnd Bergmann <arnd@arndb.de>
To: Ingo Molnar <mingo@redhat.com>, x86@kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Kees Cook <keescook@chromium.org>, Baoquan He <bhe@redhat.com>,
Thomas Garnier <thgarnie@google.com>,
Dave Jiang <dave.jiang@intel.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] x86/KASLR: use the right memcpy
Date: Tue, 30 May 2017 11:14:17 +0200 [thread overview]
Message-ID: <20170530091446.1000183-1-arnd@arndb.de> (raw)
The decompressor has its own implementation of the string functions,
but has to include the right header to get those, while implicitly
including linux/string.h may result in a link error:
arch/x86/boot/compressed/kaslr.o: In function `choose_random_location':
kaslr.c:(.text+0xf51): undefined reference to `_mmx_memcpy'
This has appeared now as kaslr started using memcpy. Other files in the
decompressor already do the same thing.
Fixes: d52e7d5a952c ("x86/KASLR: Parse all 'memmap=' boot option entries")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/x86/boot/compressed/kaslr.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/boot/compressed/kaslr.c b/arch/x86/boot/compressed/kaslr.c
index e0eba12bffe7..fe318b44f7b8 100644
--- a/arch/x86/boot/compressed/kaslr.c
+++ b/arch/x86/boot/compressed/kaslr.c
@@ -30,6 +30,7 @@
#include "misc.h"
#include "error.h"
+#include "../string.h"
#include <generated/compile.h>
#include <linux/module.h>
--
2.9.0
next reply other threads:[~2017-05-30 9:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 9:14 Arnd Bergmann [this message]
2017-05-30 13:56 ` Baoquan He
2017-05-30 14:24 ` Arnd Bergmann
2017-05-31 1:43 ` Baoquan He
2017-05-31 9:40 ` [tip:x86/boot] x86/KASLR: Use the right memcpy() implementation tip-bot for Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170530091446.1000183-1-arnd@arndb.de \
--to=arnd@arndb.de \
--cc=bhe@redhat.com \
--cc=dave.jiang@intel.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=thgarnie@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome