* [PATCH] drm/pl111: select DRM_PANEL
@ 2017-05-30 9:22 Arnd Bergmann
2017-05-30 11:35 ` Linus Walleij
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2017-05-30 9:22 UTC (permalink / raw)
To: Eric Anholt, David Airlie
Cc: Arnd Bergmann, Linus Walleij, Daniel Vetter, Tom Cooksey,
dri-devel, linux-kernel
When DRM_PANEL is disabled, we get a link error for pl111:
drivers/gpu/built-in.o: In function `pl111_connector_destroy':
pl111_connector.c:(.text+0x3487e6): undefined reference to `drm_panel_detach'
For some reason this only appears in the latest linux-next
although the driver appears to have used the symbol for a few
weeks already. The solution however is simple enough, we just
need to add a 'select' statement.
Fixes: bed41005e617 ("drm/pl111: Initial drm/kms driver for pl111")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/pl111/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/pl111/Kconfig b/drivers/gpu/drm/pl111/Kconfig
index 309f4fd52de7..bbfba87cd1a8 100644
--- a/drivers/gpu/drm/pl111/Kconfig
+++ b/drivers/gpu/drm/pl111/Kconfig
@@ -6,6 +6,7 @@ config DRM_PL111
select DRM_KMS_HELPER
select DRM_KMS_CMA_HELPER
select DRM_GEM_CMA_HELPER
+ select DRM_PANEL
select VT_HW_CONSOLE_BINDING if FRAMEBUFFER_CONSOLE
help
Choose this option for DRM support for the PL111 CLCD controller.
--
2.9.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/pl111: select DRM_PANEL
2017-05-30 9:22 [PATCH] drm/pl111: select DRM_PANEL Arnd Bergmann
@ 2017-05-30 11:35 ` Linus Walleij
2017-05-31 7:18 ` Daniel Vetter
0 siblings, 1 reply; 3+ messages in thread
From: Linus Walleij @ 2017-05-30 11:35 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Eric Anholt, David Airlie, Daniel Vetter, Tom Cooksey,
open list:DRM PANEL DRIVERS, linux-kernel
On Tue, May 30, 2017 at 11:22 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> When DRM_PANEL is disabled, we get a link error for pl111:
>
> drivers/gpu/built-in.o: In function `pl111_connector_destroy':
> pl111_connector.c:(.text+0x3487e6): undefined reference to `drm_panel_detach'
>
> For some reason this only appears in the latest linux-next
> although the driver appears to have used the symbol for a few
> weeks already. The solution however is simple enough, we just
> need to add a 'select' statement.
>
> Fixes: bed41005e617 ("drm/pl111: Initial drm/kms driver for pl111")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Tested-by: Linus Walleij <linus.walleij@linaro.org>
I had the same patch in my tree, just haven't had time to send
it out.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/pl111: select DRM_PANEL
2017-05-30 11:35 ` Linus Walleij
@ 2017-05-31 7:18 ` Daniel Vetter
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2017-05-31 7:18 UTC (permalink / raw)
To: Linus Walleij
Cc: Arnd Bergmann, Eric Anholt, David Airlie, Daniel Vetter,
Tom Cooksey, open list:DRM PANEL DRIVERS, linux-kernel
On Tue, May 30, 2017 at 01:35:51PM +0200, Linus Walleij wrote:
> On Tue, May 30, 2017 at 11:22 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>
> > When DRM_PANEL is disabled, we get a link error for pl111:
> >
> > drivers/gpu/built-in.o: In function `pl111_connector_destroy':
> > pl111_connector.c:(.text+0x3487e6): undefined reference to `drm_panel_detach'
> >
> > For some reason this only appears in the latest linux-next
> > although the driver appears to have used the symbol for a few
> > weeks already. The solution however is simple enough, we just
> > need to add a 'select' statement.
> >
> > Fixes: bed41005e617 ("drm/pl111: Initial drm/kms driver for pl111")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Tested-by: Linus Walleij <linus.walleij@linaro.org>
>
> I had the same patch in my tree, just haven't had time to send
> it out.
Eric seems out, so I picked this up for him. Thanks for the patch&testing.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-31 7:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-30 9:22 [PATCH] drm/pl111: select DRM_PANEL Arnd Bergmann
2017-05-30 11:35 ` Linus Walleij
2017-05-31 7:18 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®