From: Arnd Bergmann <arnd@arndb.de>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Yuvaraj Kumar C D <yuvaraj.cd@gmail.com>,
Girish K S <ks.giri@samsung.com>,
Vasanth Ananthan <vasanth.a@samsung.com>,
Arnd Bergmann <arnd@arndb.de>,
Jaehoon Chung <jh80.chung@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH] PHY: Exynos: fix I2C dependency for Exynos5250 SATA
Date: Tue, 30 May 2017 11:28:25 +0200 [thread overview]
Message-ID: <20170530092858.1351047-1-arnd@arndb.de> (raw)
Device drivers should not 'select' other subsystems, but rather use
'depends on', to avoid Kconfig dependency loops. This one even
selects a particular I2C host driver for no reason, so we can
remove the select of that particular driver, and turn the I2C
'select' into 'depends on'.
Fixes: bcff4cba41bc ("PHY: Exynos: Add Exynos5250 SATA PHY driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/phy/samsung/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/phy/samsung/Kconfig b/drivers/phy/samsung/Kconfig
index b7e0645a7bd9..76475b01780d 100644
--- a/drivers/phy/samsung/Kconfig
+++ b/drivers/phy/samsung/Kconfig
@@ -83,10 +83,9 @@ config PHY_EXYNOS5250_SATA
tristate "Exynos5250 Sata SerDes/PHY driver"
depends on SOC_EXYNOS5250
depends on HAS_IOMEM
+ depends on I2C
depends on OF
select GENERIC_PHY
- select I2C
- select I2C_S3C2410
select MFD_SYSCON
help
Enable this to support SATA SerDes/Phy found on Samsung's
--
2.9.0
next reply other threads:[~2017-05-30 9:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 9:28 Arnd Bergmann [this message]
2017-05-31 10:12 ` Krzysztof Kozlowski
2017-05-31 10:25 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170530092858.1351047-1-arnd@arndb.de \
--to=arnd@arndb.de \
--cc=jh80.chung@samsung.com \
--cc=kishon@ti.com \
--cc=krzk@kernel.org \
--cc=ks.giri@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vasanth.a@samsung.com \
--cc=yuvaraj.cd@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®