From: Lee Jones <lee.jones@linaro.org>
To: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/15] mfd: fsl-imx25: use devm_of_platform_populate()
Date: Tue, 30 May 2017 10:31:11 +0100 [thread overview]
Message-ID: <20170530093111.cw5d2gxfmcxtgl34@dell> (raw)
In-Reply-To: <1496072763-31209-10-git-send-email-benjamin.gaignard@linaro.org>
On Mon, 29 May 2017, Benjamin Gaignard wrote:
> Use devm_of_platform_populate() to be sure that of_platform_depopulate
> is called when removing the driver.
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
>
> CC: Lee Jones <lee.jones@linaro.org>
> CC: linux-kernel@vger.kernel.org
> ---
> drivers/mfd/fsl-imx25-tsadc.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/fsl-imx25-tsadc.c b/drivers/mfd/fsl-imx25-tsadc.c
> index ac430a3..4258a42 100644
> --- a/drivers/mfd/fsl-imx25-tsadc.c
> +++ b/drivers/mfd/fsl-imx25-tsadc.c
> @@ -129,7 +129,6 @@ static void mx25_tsadc_setup_clk(struct platform_device *pdev,
> static int mx25_tsadc_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> - struct device_node *np = dev->of_node;
> struct mx25_tsadc *tsadc;
> struct resource *res;
> int ret;
> @@ -178,9 +177,7 @@ static int mx25_tsadc_probe(struct platform_device *pdev)
>
> platform_set_drvdata(pdev, tsadc);
>
> - of_platform_populate(np, NULL, NULL, dev);
> -
> - return 0;
> + return devm_of_platform_populate(dev);
> }
>
> static const struct of_device_id mx25_tsadc_ids[] = {
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2017-05-30 9:31 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-29 15:45 [PATCH 00/15] make more driver " Benjamin Gaignard
2017-05-29 15:45 ` [PATCH 01/15] iio: adc: stm32: " Benjamin Gaignard
2017-05-29 16:00 ` Jonathan Cameron
2017-05-29 16:03 ` Fabrice Gasnier
2017-05-29 15:45 ` [PATCH 02/15] iio: dac: " Benjamin Gaignard
2017-05-29 16:10 ` Fabrice Gasnier
2017-05-29 15:45 ` [PATCH 03/15] drm: zte: " Benjamin Gaignard
2017-06-05 1:59 ` Shawn Guo
2017-05-29 15:45 ` [PATCH 04/15] drm: msm: " Benjamin Gaignard
2017-05-29 15:45 ` [PATCH 05/15] mfd: stm32-timers: use devm_of_platform_populate Benjamin Gaignard
2017-05-30 9:29 ` Lee Jones
2017-05-29 15:45 ` [PATCH 06/15] mfd: atmel: use devm_of_platform_populate() Benjamin Gaignard
2017-05-30 9:30 ` Lee Jones
2017-05-29 15:45 ` [PATCH 07/15] mfd: cros_ec: " Benjamin Gaignard
2017-05-30 9:30 ` Lee Jones
2017-05-29 15:45 ` [PATCH 08/15] mfd: exynos: " Benjamin Gaignard
2017-05-30 9:31 ` Lee Jones
2017-05-29 15:45 ` [PATCH 09/15] mfd: fsl-imx25: " Benjamin Gaignard
2017-05-30 9:31 ` Lee Jones [this message]
2017-05-29 15:45 ` [PATCH 10/15] mfd: motorola-cpcap: " Benjamin Gaignard
2017-05-29 22:07 ` Andy Shevchenko
2017-05-30 7:29 ` Benjamin Gaignard
2017-05-30 10:03 ` Lee Jones
2017-05-30 10:46 ` Andy Shevchenko
2017-05-30 10:09 ` Lee Jones
2017-05-29 15:45 ` [PATCH 11/15] mfd: palmas: " Benjamin Gaignard
2017-05-30 9:31 ` Lee Jones
2017-05-29 15:46 ` [PATCH 12/15] mfd: qcom-spmi-pmic: " Benjamin Gaignard
2017-05-30 9:32 ` Lee Jones
2017-05-29 15:46 ` [PATCH 13/15] mfd: smsc-ece: " Benjamin Gaignard
2017-05-30 9:32 ` Lee Jones
2017-05-29 15:46 ` [PATCH 14/15] sound: stm32: " Benjamin Gaignard
2017-05-30 9:03 ` Olivier MOYSAN
2017-05-29 15:46 ` [PATCH 15/15] media: exynos4-is: " Benjamin Gaignard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170530093111.cw5d2gxfmcxtgl34@dell \
--to=lee.jones@linaro.org \
--cc=benjamin.gaignard@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®