* [PATCH] gpio: xra1403: select REGMAP_SPI
@ 2017-05-30 11:13 Arnd Bergmann
2017-05-30 11:48 ` Han, Nandor (GE Healthcare)
2017-05-31 0:14 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2017-05-30 11:13 UTC (permalink / raw)
To: Linus Walleij; +Cc: Nandor Han, Arnd Bergmann, linux-gpio, linux-kernel
Without the regmap code, we get a link error:
drivers/gpio/built-in.o: In function `xra1403_probe':
(.text+0x132e0): undefined reference to `__devm_regmap_init_spi'
Fixes: 5704520d7880 ("gpio: xra1403: Add EXAR XRA1403 SPI GPIO expander driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpio/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 66d1f353ca73..238fc231081a 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -1241,6 +1241,7 @@ config GPIO_PISOSR
config GPIO_XRA1403
tristate "EXAR XRA1403 16-bit GPIO expander"
+ select REGMAP_SPI
help
GPIO driver for EXAR XRA1403 16-bit SPI-based GPIO expander.
--
2.9.0
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [PATCH] gpio: xra1403: select REGMAP_SPI
2017-05-30 11:13 [PATCH] gpio: xra1403: select REGMAP_SPI Arnd Bergmann
@ 2017-05-30 11:48 ` Han, Nandor (GE Healthcare)
2017-05-31 0:14 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Han, Nandor (GE Healthcare) @ 2017-05-30 11:48 UTC (permalink / raw)
To: Arnd Bergmann, Linus Walleij; +Cc: linux-gpio, linux-kernel
> -----Original Message-----
> From: Arnd Bergmann [mailto:arnd@arndb.de]
> Sent: 30 May 2017 14:13
> To: Linus Walleij <linus.walleij@linaro.org>
> Cc: Han, Nandor (GE Healthcare) <nandor.han@ge.com>; Arnd Bergmann <arnd@arndb.de>; linux-gpio@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Subject: EXT: [PATCH] gpio: xra1403: select REGMAP_SPI
>
> Without the regmap code, we get a link error:
>
> drivers/gpio/built-in.o: In function `xra1403_probe':
> (.text+0x132e0): undefined reference to `__devm_regmap_init_spi'
>
> Fixes: 5704520d7880 ("gpio: xra1403: Add EXAR XRA1403 SPI GPIO expander driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Nandor Han <nandor.han@ge.com>
> ---
> drivers/gpio/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 66d1f353ca73..238fc231081a 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -1241,6 +1241,7 @@ config GPIO_PISOSR
>
> config GPIO_XRA1403
> tristate "EXAR XRA1403 16-bit GPIO expander"
> + select REGMAP_SPI
> help
> GPIO driver for EXAR XRA1403 16-bit SPI-based GPIO expander.
>
> --
> 2.9.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] gpio: xra1403: select REGMAP_SPI
2017-05-30 11:13 [PATCH] gpio: xra1403: select REGMAP_SPI Arnd Bergmann
2017-05-30 11:48 ` Han, Nandor (GE Healthcare)
@ 2017-05-31 0:14 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2017-05-31 0:14 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Nandor Han, linux-gpio, linux-kernel
On Tue, May 30, 2017 at 1:13 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> Without the regmap code, we get a link error:
>
> drivers/gpio/built-in.o: In function `xra1403_probe':
> (.text+0x132e0): undefined reference to `__devm_regmap_init_spi'
>
> Fixes: 5704520d7880 ("gpio: xra1403: Add EXAR XRA1403 SPI GPIO expander driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-31 0:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-30 11:13 [PATCH] gpio: xra1403: select REGMAP_SPI Arnd Bergmann
2017-05-30 11:48 ` Han, Nandor (GE Healthcare)
2017-05-31 0:14 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®