From: David Miller <davem@davemloft.net>
To: jon.mason@broadcom.com
Cc: andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH net-next] mdio: mux: make child bus walking more permissive and errors more verbose
Date: Sun, 04 Jun 2017 19:30:58 -0400 (EDT) [thread overview]
Message-ID: <20170604.193058.256838162791393085.davem@davemloft.net> (raw)
In-Reply-To: <1496259890-3719-1-git-send-email-jon.mason@broadcom.com>
From: Jon Mason <jon.mason@broadcom.com>
Date: Wed, 31 May 2017 15:44:50 -0400
> If any errors are encountered while walking the device tree structure of
> the MDIO bus for children, the code may silently continue, silently
> exit, or throw an error and exit. This make it difficult for device
> tree writers to know there is an error. Also, it makes any error in a
> child entry of the MDIO bus be fatal for all entries. Instead, we
> should provide verbose errors describing the error and then attempt to
> continue if it all possible. Also, use of_mdio_parse_addr()
>
> Signed-off-by: Jon Mason <jon.mason@broadcom.com>
Looks good. Every conversion from break to continue properly gets rid
of the child_bus_node release, and this new behavior matches what was
discussed a few weeks ago.
Applied, thanks.
prev parent reply other threads:[~2017-06-04 23:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 19:44 Jon Mason
2017-06-04 23:30 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170604.193058.256838162791393085.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=jon.mason@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®