From: David Miller <davem@davemloft.net>
To: colin.king@canonical.com
Cc: andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][V2] net: phy: marvell: make some functions static
Date: Sun, 04 Jun 2017 19:55:49 -0400 (EDT) [thread overview]
Message-ID: <20170604.195549.1999857552284832975.davem@davemloft.net> (raw)
In-Reply-To: <20170602141334.26506-1-colin.king@canonical.com>
From: Colin King <colin.king@canonical.com>
Date: Fri, 2 Jun 2017 15:13:34 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> functions m88e1510_get_temp_critical, m88e1510_set_temp_critical and
> m88e1510_get_temp_alarm can be made static as they not need to be
> in global scope.
>
> Cleans up sparse warnings:
> "symbol 'm88e1510_get_temp_alarm' was not declared. Should it be static?"
> "symbol 'm88e1510_get_temp_critical' was not declared. Should it be
> static?"
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied to net-next, thanks.
prev parent reply other threads:[~2017-06-04 23:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 14:13 Colin King
2017-06-02 16:48 ` Florian Fainelli
2017-06-04 23:55 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170604.195549.1999857552284832975.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=colin.king@canonical.com \
--cc=f.fainelli@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®