From: Florian Fainelli <f.fainelli@gmail.com>
To: Colin King <colin.king@canonical.com>,
Andrew Lunn <andrew@lunn.ch>,
netdev@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][V2] net: phy: marvell: make some functions static
Date: Fri, 2 Jun 2017 09:48:29 -0700 [thread overview]
Message-ID: <5268b842-3784-36f7-7c6f-e1b4b670f8b5@gmail.com> (raw)
In-Reply-To: <20170602141334.26506-1-colin.king@canonical.com>
On 06/02/2017 07:13 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> functions m88e1510_get_temp_critical, m88e1510_set_temp_critical and
> m88e1510_get_temp_alarm can be made static as they not need to be
> in global scope.
>
> Cleans up sparse warnings:
> "symbol 'm88e1510_get_temp_alarm' was not declared. Should it be static?"
> "symbol 'm88e1510_get_temp_critical' was not declared. Should it be
> static?"
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2017-06-02 16:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 14:13 Colin King
2017-06-02 16:48 ` Florian Fainelli [this message]
2017-06-04 23:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5268b842-3784-36f7-7c6f-e1b4b670f8b5@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®