From: David Miller <davem@davemloft.net>
To: mhocko@kernel.org
Cc: thomas.lendacky@amd.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, mhocko@suse.com
Subject: Re: [PATCH] amd-xgbe: use PAGE_ALLOC_COSTLY_ORDER in xgbe_map_rx_buffer
Date: Sun, 04 Jun 2017 20:01:19 -0400 (EDT) [thread overview]
Message-ID: <20170604.200119.791002119725193988.davem@davemloft.net> (raw)
In-Reply-To: <20170602155408.12792-1-mhocko@kernel.org>
From: Michal Hocko <mhocko@kernel.org>
Date: Fri, 2 Jun 2017 17:54:08 +0200
> From: Michal Hocko <mhocko@suse.com>
>
> xgbe_map_rx_buffer is rather confused about what PAGE_ALLOC_COSTLY_ORDER
> means. It uses PAGE_ALLOC_COSTLY_ORDER-1 assuming that
> PAGE_ALLOC_COSTLY_ORDER is the first costly order which is not the case
> actually because orders larger than that are costly. And even that
> applies only to sleeping allocations which is not the case here. We
> simply do not perform any costly operations like reclaim or compaction
> for those. Simplify the code by dropping the order calculation and use
> PAGE_ALLOC_COSTLY_ORDER directly.
>
> Signed-off-by: Michal Hocko <mhocko@suse.com>
Applied.
next prev parent reply other threads:[~2017-06-05 0:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 15:54 Michal Hocko
2017-06-02 20:52 ` Tom Lendacky
2017-06-05 0:01 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-06-02 14:43 strange PAGE_ALLOC_COSTLY_ORDER usage " Michal Hocko
2017-06-03 1:25 ` [PATCH] amd-xgbe: use PAGE_ALLOC_COSTLY_ORDER " kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170604.200119.791002119725193988.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=netdev@vger.kernel.org \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®