mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johannes Thumshirn <jthumshirn@suse.de>
To: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
	Keith Busch <keith.busch@intel.com>
Cc: Hannes Reinecke <hare@suse.de>,
	maxg@mellanox.com,
	Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>,
	Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
	Johannes Thumshirn <jthumshirn@suse.de>
Subject: [PATCH v5 6/9] nvmet: add uuid field to nvme_ns and populate via configfs
Date: Tue,  6 Jun 2017 16:36:14 +0200	[thread overview]
Message-ID: <20170606143617.32143-7-jthumshirn@suse.de> (raw)
In-Reply-To: <20170606143617.32143-1-jthumshirn@suse.de>

Add the UUID field from the NVMe Namespace Identification Descriptor
to the nvmet_ns structure and allow it's population via configfs.

Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
Reviewed-by: Max Gurtovoy <maxg@mellanox.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Hannes Reinecke <hare@suse.com>
---
 drivers/nvme/target/configfs.c | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/drivers/nvme/target/configfs.c b/drivers/nvme/target/configfs.c
index be8c800078e2..83bfe28fe7da 100644
--- a/drivers/nvme/target/configfs.c
+++ b/drivers/nvme/target/configfs.c
@@ -305,11 +305,41 @@ static ssize_t nvmet_ns_device_path_store(struct config_item *item,
 
 CONFIGFS_ATTR(nvmet_ns_, device_path);
 
+static ssize_t nvmet_ns_device_uuid_show(struct config_item *item, char *page)
+{
+	return sprintf(page, "%pUb\n", &to_nvmet_ns(item)->uuid);
+}
+
+static ssize_t nvmet_ns_device_uuid_store(struct config_item *item,
+					  const char *page, size_t count)
+{
+	struct nvmet_ns *ns = to_nvmet_ns(item);
+	struct nvmet_subsys *subsys = ns->subsys;
+	int ret = 0;
+
+
+	mutex_lock(&subsys->lock);
+	if (ns->enabled) {
+		ret = -EBUSY;
+		goto out_unlock;
+	}
+
+
+	if (uuid_parse(page, &ns->uuid))
+		ret = -EINVAL;
+
+out_unlock:
+	mutex_unlock(&subsys->lock);
+	return ret ? ret : count;
+}
+
 static ssize_t nvmet_ns_device_nguid_show(struct config_item *item, char *page)
 {
 	return sprintf(page, "%pUb\n", &to_nvmet_ns(item)->nguid);
 }
 
+CONFIGFS_ATTR(nvmet_ns_, device_uuid);
+
 static ssize_t nvmet_ns_device_nguid_store(struct config_item *item,
 		const char *page, size_t count)
 {
@@ -379,6 +409,7 @@ CONFIGFS_ATTR(nvmet_ns_, enable);
 static struct configfs_attribute *nvmet_ns_attrs[] = {
 	&nvmet_ns_attr_device_path,
 	&nvmet_ns_attr_device_nguid,
+	&nvmet_ns_attr_device_uuid,
 	&nvmet_ns_attr_enable,
 	NULL,
 };
-- 
2.12.3

  parent reply	other threads:[~2017-06-06 14:38 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-06 14:36 [PATCH v5 0/9] Implement NVMe Namespace Descriptor Identification Johannes Thumshirn
2017-06-06 14:36 ` [PATCH v5 1/9] scatterlist: add sg_zeroout_area() helper Johannes Thumshirn
2017-06-06 18:26   ` Sagi Grimberg
2017-06-07  7:00     ` Johannes Thumshirn
2017-06-06 14:36 ` [PATCH v5 2/9] nvmet: use NVME_IDENTIFY_DATA_SIZE Johannes Thumshirn
2017-06-06 14:36 ` [PATCH v5 3/9] nvme: introduce NVMe Namespace Identification Descriptor structures Johannes Thumshirn
2017-06-06 14:36 ` [PATCH v5 4/9] nvme: rename uuid to nguid in nvme_ns Johannes Thumshirn
2017-06-06 14:36 ` [PATCH v5 5/9] nvmet: implement namespace identify descriptor list Johannes Thumshirn
2017-06-07  8:55   ` Max Gurtovoy
2017-06-06 14:36 ` Johannes Thumshirn [this message]
2017-06-06 14:36 ` [PATCH v5 7/9] nvme: get list of namespace descriptors Johannes Thumshirn
2017-06-06 18:30   ` Sagi Grimberg
2017-06-07  6:57     ` Johannes Thumshirn
2017-06-06 14:36 ` [PATCH v5 8/9] nvme: provide UUID value to userspace Johannes Thumshirn
2017-06-06 14:36 ` [PATCH v5 9/9] nvmet: allow overriding the NVMe VS via configfs Johannes Thumshirn
2017-06-07  4:47   ` Guan Junxiong
2017-06-06 18:27 ` [PATCH v5 0/9] Implement NVMe Namespace Descriptor Identification Sagi Grimberg
2017-06-07  6:59   ` Johannes Thumshirn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170606143617.32143-7-jthumshirn@suse.de \
    --to=jthumshirn@suse.de \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=keith.busch@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=maxg@mellanox.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®