From: Johannes Thumshirn <jthumshirn@suse.de>
To: Sagi Grimberg <sagi@grimberg.me>, Christoph Hellwig <hch@lst.de>,
Keith Busch <keith.busch@intel.com>
Cc: Hannes Reinecke <hare@suse.de>,
maxg@mellanox.com,
Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 1/9] scatterlist: add sg_zeroout_area() helper
Date: Wed, 7 Jun 2017 09:00:50 +0200 [thread overview]
Message-ID: <0778ec96-8396-143e-9925-55f9c7d39239@suse.de> (raw)
In-Reply-To: <eef19233-47d6-9ea3-9f03-d846ce578ef7@grimberg.me>
On 06/06/2017 08:26 PM, Sagi Grimberg wrote:
>
>> + while ((offset < buflen) && sg_miter_next(&miter)) {
>> + unsigned int len;
>> +
>> + len = min(miter.length, buflen - offset);
>> + memset(miter.addr, '\0', len);
>
> Why '\0' and not 0?
Shouldn't be a difference, should it? ascii(7) says
'000 0 00 NUL '\0' (null character)'
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2017-06-07 7:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 14:36 [PATCH v5 0/9] Implement NVMe Namespace Descriptor Identification Johannes Thumshirn
2017-06-06 14:36 ` [PATCH v5 1/9] scatterlist: add sg_zeroout_area() helper Johannes Thumshirn
2017-06-06 18:26 ` Sagi Grimberg
2017-06-07 7:00 ` Johannes Thumshirn [this message]
2017-06-06 14:36 ` [PATCH v5 2/9] nvmet: use NVME_IDENTIFY_DATA_SIZE Johannes Thumshirn
2017-06-06 14:36 ` [PATCH v5 3/9] nvme: introduce NVMe Namespace Identification Descriptor structures Johannes Thumshirn
2017-06-06 14:36 ` [PATCH v5 4/9] nvme: rename uuid to nguid in nvme_ns Johannes Thumshirn
2017-06-06 14:36 ` [PATCH v5 5/9] nvmet: implement namespace identify descriptor list Johannes Thumshirn
2017-06-07 8:55 ` Max Gurtovoy
2017-06-06 14:36 ` [PATCH v5 6/9] nvmet: add uuid field to nvme_ns and populate via configfs Johannes Thumshirn
2017-06-06 14:36 ` [PATCH v5 7/9] nvme: get list of namespace descriptors Johannes Thumshirn
2017-06-06 18:30 ` Sagi Grimberg
2017-06-07 6:57 ` Johannes Thumshirn
2017-06-06 14:36 ` [PATCH v5 8/9] nvme: provide UUID value to userspace Johannes Thumshirn
2017-06-06 14:36 ` [PATCH v5 9/9] nvmet: allow overriding the NVMe VS via configfs Johannes Thumshirn
2017-06-07 4:47 ` Guan Junxiong
2017-06-06 18:27 ` [PATCH v5 0/9] Implement NVMe Namespace Descriptor Identification Sagi Grimberg
2017-06-07 6:59 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0778ec96-8396-143e-9925-55f9c7d39239@suse.de \
--to=jthumshirn@suse.de \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=maxg@mellanox.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®