From: Borislav Petkov <bp@alien8.de>
To: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
Cc: "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] EDAC: mv64x60 calculate memory size correctly
Date: Tue, 6 Jun 2017 18:55:18 +0200 [thread overview]
Message-ID: <20170606165518.2hitef2pbjavjww4@pd.tnic> (raw)
In-Reply-To: <33f892b086ec4d638ed5c955bec68303@svr-chch-ex1.atlnz.lc>
On Tue, Jun 06, 2017 at 03:07:04AM +0000, Chris Packham wrote:
> I'll wait for feedback before sending a v2.
You can't be expecting me to review PPC code reliably. :-)
AFAIR from the recent discussion, Michael said that the aim is to remove
CONFIG_MV64X60 and since this driver depends on it, that would make it
obsolete too.
But I don't think we've ever "hijacked" a driver and renamed it to be
used as a driver on a different architecture - that would be just too
unorthodox.
So if I had to decide, I'd suggest you create your own armada_edac.c or
whatever that is and put your code there. Or, if you're going to support
multiple Marvell chips, then call it mv_edac.c or marvell_edac.c or so
and start building a fine driver there.
How does that sound?
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2017-06-06 16:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 2:41 Chris Packham
2017-06-06 3:07 ` Chris Packham
2017-06-06 16:55 ` Borislav Petkov [this message]
2017-06-06 21:19 ` Chris Packham
2017-06-07 9:01 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170606165518.2hitef2pbjavjww4@pd.tnic \
--to=bp@alien8.de \
--cc=Chris.Packham@alliedtelesis.co.nz \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®