From: Christoph Hellwig <hch@infradead.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: David Kershner <david.kershner@unisys.com>,
corbet@lwn.net, tglx@linutronix.de, mingo@kernel.org,
akpm@linux-foundation.org, jes.sorensen@gmail.com,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
driverdev-devel@linuxdriverproject.org,
sparmaintainer@unisys.com
Subject: Re: [PATCH 0/3] move visorbus out of staging to drivers/virt/visorbus
Date: Wed, 7 Jun 2017 06:59:52 -0700 [thread overview]
Message-ID: <20170607135952.GB20110@infradead.org> (raw)
In-Reply-To: <20170606144909.GA31938@kroah.com>
On Tue, Jun 06, 2017 at 04:49:09PM +0200, Greg KH wrote:
> On Mon, Jun 05, 2017 at 04:07:29PM -0400, David Kershner wrote:
> > This patchset moves drivers/staging/unisys/include to
> > include/linux/visorbus, and moves drivers/staging/unisys/visorbus to
> > drivers/virt/visorbus.
>
> Um, are you thinking it is ready to be moved? Have you asked for
> another review?
>
> In a totally random chance, I was doing some driver core work today and
> I noticed that in drivers/staging/unisys/visorbus/visorbus_main.c, you
> have 2 tabs for your 'struct attribute' variables, which is really odd.
That's the least of the problems. Just about any function in there is
doing functionally stupid things. E.g. raw sg_phys() calls for I/O
instead of dma mapping routines or parsing SCSI INQUIRY data in the
driver.
next prev parent reply other threads:[~2017-06-07 13:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-05 20:07 David Kershner
2017-06-05 20:07 ` [PATCH 1/3] include: linux: visorbus: Add visorbus to include/linux directory David Kershner
2017-06-07 13:58 ` Christoph Hellwig
2017-06-05 20:07 ` [PATCH 2/3] Documentation: Move visorbus documentation from staging to Documentation/ David Kershner
2017-06-06 8:02 ` Jani Nikula
2017-06-05 20:07 ` [PATCH 3/3] drivers: virt: Add visorbus to the drivers/virt directory David Kershner
2017-06-06 21:47 ` kbuild test robot
2017-06-06 14:49 ` [PATCH 0/3] move visorbus out of staging to drivers/virt/visorbus Greg KH
2017-06-06 14:53 ` Greg KH
2017-06-06 14:54 ` Greg KH
2017-06-06 15:06 ` Greg KH
2017-06-06 18:20 ` Kershner, David A
2017-06-06 18:58 ` Greg KH
2017-06-06 15:33 ` Joe Perches
2017-06-06 15:39 ` Greg KH
2017-06-06 15:52 ` Joe Perches
2017-06-06 16:01 ` Greg KH
2017-06-07 13:59 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-06-11 3:23 David Kershner
2016-06-14 13:30 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170607135952.GB20110@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=david.kershner@unisys.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=jes.sorensen@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=sparmaintainer@unisys.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®