mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] ARM/Kconfig: make VMSPLIT_3G_OPT depends on !ARM_LPAE
@ 2017-06-08  6:05 Yisheng Xie
  2017-06-08 16:04 ` Nicolas Pitre
  2017-06-08 16:09 ` Russell King - ARM Linux
  0 siblings, 2 replies; 3+ messages in thread
From: Yisheng Xie @ 2017-06-08  6:05 UTC (permalink / raw)
  To: linux
  Cc: rmk+kernel, matthias.bgg, viro, nico, catalin.marinas,
	will.deacon, guohanjun, wangfangpeng1, linux-arm-kernel,
	linux-kernel

When both enable CONFIG_ARM_LPAE=y and CONFIG_VMSPLIT_3G_OPT=y, which
means use PAGE_OFFSET=0xB0000000 with ARM_LPAE, the kernel will boot
fail and stop after uncompressed:

   Starting kernel ...

   Uart base = 0x20001000
   watchdog reg = 0x20013000
   dtb addr = 0x80840308
   Uncompressing Linux... done, booting the kernel.

For ARM_LPAE only support 3:1, 2:2, 1:3 split of TTBR1, which mention in:
   http://elinux.org/images/6/6a/Elce11_marinas.pdf - p16

So we should make VMSPLIT_3G_OPT depends on !ARM_LPAE to avoid trigger
this bug.

Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
---
 arch/arm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 4c1a35f..c0fcab6 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1416,6 +1416,7 @@ choice
 	config VMSPLIT_3G
 		bool "3G/1G user/kernel split"
 	config VMSPLIT_3G_OPT
+		depends on !ARM_LPAE
 		bool "3G/1G user/kernel split (for full 1G low memory)"
 	config VMSPLIT_2G
 		bool "2G/2G user/kernel split"
-- 
1.7.12.4

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM/Kconfig: make VMSPLIT_3G_OPT depends on !ARM_LPAE
  2017-06-08  6:05 [PATCH] ARM/Kconfig: make VMSPLIT_3G_OPT depends on !ARM_LPAE Yisheng Xie
@ 2017-06-08 16:04 ` Nicolas Pitre
  2017-06-08 16:09 ` Russell King - ARM Linux
  1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Pitre @ 2017-06-08 16:04 UTC (permalink / raw)
  To: Yisheng Xie
  Cc: linux, catalin.marinas, will.deacon, linux-kernel, viro,
	wangfangpeng1, guohanjun, matthias.bgg, rmk+kernel,
	linux-arm-kernel

On Thu, 8 Jun 2017, Yisheng Xie wrote:

> When both enable CONFIG_ARM_LPAE=y and CONFIG_VMSPLIT_3G_OPT=y, which
> means use PAGE_OFFSET=0xB0000000 with ARM_LPAE, the kernel will boot
> fail and stop after uncompressed:
> 
>    Starting kernel ...
> 
>    Uart base = 0x20001000
>    watchdog reg = 0x20013000
>    dtb addr = 0x80840308
>    Uncompressing Linux... done, booting the kernel.
> 
> For ARM_LPAE only support 3:1, 2:2, 1:3 split of TTBR1, which mention in:
>    http://elinux.org/images/6/6a/Elce11_marinas.pdf - p16
> 
> So we should make VMSPLIT_3G_OPT depends on !ARM_LPAE to avoid trigger
> this bug.
> 
> Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>

Acked-by: Nicolas Pitre <nico@linaro.org>


> ---
>  arch/arm/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 4c1a35f..c0fcab6 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1416,6 +1416,7 @@ choice
>  	config VMSPLIT_3G
>  		bool "3G/1G user/kernel split"
>  	config VMSPLIT_3G_OPT
> +		depends on !ARM_LPAE
>  		bool "3G/1G user/kernel split (for full 1G low memory)"
>  	config VMSPLIT_2G
>  		bool "2G/2G user/kernel split"
> -- 
> 1.7.12.4
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM/Kconfig: make VMSPLIT_3G_OPT depends on !ARM_LPAE
  2017-06-08  6:05 [PATCH] ARM/Kconfig: make VMSPLIT_3G_OPT depends on !ARM_LPAE Yisheng Xie
  2017-06-08 16:04 ` Nicolas Pitre
@ 2017-06-08 16:09 ` Russell King - ARM Linux
  1 sibling, 0 replies; 3+ messages in thread
From: Russell King - ARM Linux @ 2017-06-08 16:09 UTC (permalink / raw)
  To: Yisheng Xie
  Cc: matthias.bgg, viro, nico, catalin.marinas, will.deacon,
	guohanjun, wangfangpeng1, linux-arm-kernel, linux-kernel

On Thu, Jun 08, 2017 at 02:05:44PM +0800, Yisheng Xie wrote:
> When both enable CONFIG_ARM_LPAE=y and CONFIG_VMSPLIT_3G_OPT=y, which
> means use PAGE_OFFSET=0xB0000000 with ARM_LPAE, the kernel will boot
> fail and stop after uncompressed:
> 
>    Starting kernel ...
> 
>    Uart base = 0x20001000
>    watchdog reg = 0x20013000
>    dtb addr = 0x80840308
>    Uncompressing Linux... done, booting the kernel.
> 
> For ARM_LPAE only support 3:1, 2:2, 1:3 split of TTBR1, which mention in:
>    http://elinux.org/images/6/6a/Elce11_marinas.pdf - p16
> 
> So we should make VMSPLIT_3G_OPT depends on !ARM_LPAE to avoid trigger
> this bug.

Yes, this is much more preferable.  Please drop it into the patch system,
thanks.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-06-08 16:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-08  6:05 [PATCH] ARM/Kconfig: make VMSPLIT_3G_OPT depends on !ARM_LPAE Yisheng Xie
2017-06-08 16:04 ` Nicolas Pitre
2017-06-08 16:09 ` Russell King - ARM Linux

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®