* [PATCH] Drivers: unisys: visorhba - style fix
@ 2017-06-09 5:15 Derek Robson
2017-06-09 14:32 ` Kershner, David A
2017-06-10 11:27 ` Dan Carpenter
0 siblings, 2 replies; 3+ messages in thread
From: Derek Robson @ 2017-06-09 5:15 UTC (permalink / raw)
To: david.kershner, gregkh, david.binder, timothy.sell,
sameer.wadgaonkar, bryan.thompson, robsonde
Cc: sparmaintainer, devel, linux-kernel
Fixed style of permissions to octal.
Found using checkpatch
Signed-off-by: Derek Robson <robsonde@gmail.com>
---
drivers/staging/unisys/visorhba/visorhba_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c b/drivers/staging/unisys/visorhba/visorhba_main.c
index 2fd31c9762c6..a6e7a6bbc428 100644
--- a/drivers/staging/unisys/visorhba/visorhba_main.c
+++ b/drivers/staging/unisys/visorhba/visorhba_main.c
@@ -1090,7 +1090,7 @@ static int visorhba_probe(struct visor_device *dev)
goto err_scsi_remove_host;
}
devdata->debugfs_info =
- debugfs_create_file("info", S_IRUSR | S_IRGRP,
+ debugfs_create_file("info", 0440,
devdata->debugfs_dir, devdata,
&info_debugfs_fops);
if (!devdata->debugfs_info) {
--
2.13.0
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [PATCH] Drivers: unisys: visorhba - style fix
2017-06-09 5:15 [PATCH] Drivers: unisys: visorhba - style fix Derek Robson
@ 2017-06-09 14:32 ` Kershner, David A
2017-06-10 11:27 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: Kershner, David A @ 2017-06-09 14:32 UTC (permalink / raw)
To: Derek Robson, gregkh, Binder, David Anthony, Sell, Timothy C,
Wadgaonkar, Sameer Laxmikant, Thompson, Bryan E.
Cc: *S-Par-Maintainer, devel, linux-kernel
> -----Original Message-----
> From: Derek Robson [mailto:robsonde@gmail.com]
> Sent: Friday, June 9, 2017 1:16 AM
> To: Kershner, David A <David.Kershner@unisys.com>;
> gregkh@linuxfoundation.org; Binder, David Anthony
> <David.Binder@unisys.com>; Sell, Timothy C <Timothy.Sell@unisys.com>;
> Wadgaonkar, Sameer Laxmikant <Sameer.Wadgaonkar@unisys.com>;
> Thompson, Bryan E. <bryan.thompson@unisys.com>; robsonde@gmail.com
> Cc: *S-Par-Maintainer <SParMaintainer@unisys.com>;
> devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] Drivers: unisys: visorhba - style fix
>
> Fixed style of permissions to octal.
> Found using checkpatch
>
> Signed-off-by: Derek Robson <robsonde@gmail.com>
Acked-by: David Kershner <david.kershner@unisys.com>
> ---
> drivers/staging/unisys/visorhba/visorhba_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c
> b/drivers/staging/unisys/visorhba/visorhba_main.c
> index 2fd31c9762c6..a6e7a6bbc428 100644
> --- a/drivers/staging/unisys/visorhba/visorhba_main.c
> +++ b/drivers/staging/unisys/visorhba/visorhba_main.c
> @@ -1090,7 +1090,7 @@ static int visorhba_probe(struct visor_device *dev)
> goto err_scsi_remove_host;
> }
> devdata->debugfs_info =
> - debugfs_create_file("info", S_IRUSR | S_IRGRP,
> + debugfs_create_file("info", 0440,
> devdata->debugfs_dir, devdata,
> &info_debugfs_fops);
> if (!devdata->debugfs_info) {
> --
> 2.13.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Drivers: unisys: visorhba - style fix
2017-06-09 5:15 [PATCH] Drivers: unisys: visorhba - style fix Derek Robson
2017-06-09 14:32 ` Kershner, David A
@ 2017-06-10 11:27 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2017-06-10 11:27 UTC (permalink / raw)
To: Derek Robson
Cc: david.kershner, gregkh, david.binder, timothy.sell,
sameer.wadgaonkar, bryan.thompson, devel, sparmaintainer,
linux-kernel
Drivers is never a valid subsystem. Do a `git log --oneline <file>` to
look at what other people are doing. The style varies by subsystem so
you should always run that command.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-10 11:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-09 5:15 [PATCH] Drivers: unisys: visorhba - style fix Derek Robson
2017-06-09 14:32 ` Kershner, David A
2017-06-10 11:27 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome