From: Kai-Heng Feng <kai.heng.feng@canonical.com>
To: stern@rowland.harvard.edu
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
Kai-Heng Feng <kai.heng.feng@canonical.com>
Subject: [PATCH] usb: host: ehci: workaround PME bug on AMD EHCI controller
Date: Fri, 9 Jun 2017 15:22:33 +0800 [thread overview]
Message-ID: <20170609072233.5594-1-kai.heng.feng@canonical.com> (raw)
As Alan Stern points out [1], the PME signal is not enabled when
controller is in D3, therefore it's not being woken up when new deivces
get plugged in.
Workaround this bug by preventing the controller enters D3 power state.
[1] https://www.spinics.net/lists/linux-usb/msg157462.html
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
drivers/usb/host/ehci-pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c
index 93326974ff4b..616685f83954 100644
--- a/drivers/usb/host/ehci-pci.c
+++ b/drivers/usb/host/ehci-pci.c
@@ -181,6 +181,8 @@ static int ehci_pci_setup(struct usb_hcd *hcd)
if (pdev->device == 0x7808) {
ehci->use_dummy_qh = 1;
ehci_info(ehci, "applying AMD SB700/SB800/Hudson-2/3 EHCI dummy qh workaround\n");
+
+ pdev->dev_flags |= PCI_DEV_FLAGS_NO_D3;
}
break;
case PCI_VENDOR_ID_VIA:
--
2.13.0
next reply other threads:[~2017-06-09 7:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 7:22 Kai-Heng Feng [this message]
2017-06-09 14:43 ` Alan Stern
2017-06-12 7:04 ` Kai-Heng Feng
2017-06-12 10:12 ` Kai-Heng Feng
2017-06-12 14:18 ` Alan Stern
2017-06-13 4:21 ` Kai-Heng Feng
2017-06-13 17:28 ` Bjorn Helgaas
2017-06-14 18:55 ` Alan Stern
2017-06-15 7:02 ` Kai-Heng Feng
2017-06-15 13:23 ` Bjorn Helgaas
2017-06-15 6:57 ` Kai-Heng Feng
2017-06-15 14:12 ` Alan Stern
2017-06-16 3:07 ` Kai-Heng Feng
2017-06-16 16:18 ` Kai-Heng Feng
2017-06-16 17:30 ` Alan Stern
2017-06-19 3:30 ` Kai-Heng Feng
2017-06-19 17:45 ` Bjorn Helgaas
2017-06-19 18:32 ` Alan Stern
2017-06-19 22:00 ` Rafael J. Wysocki
2017-06-20 2:36 ` Kai-Heng Feng
2017-06-23 0:48 ` [PATCH] PCI / PM: Avoid using device_may_wakeup() for runtime PM Rafael J. Wysocki
2017-06-23 12:58 ` [PATCH v2] " Rafael J. Wysocki
2017-06-29 22:37 ` Rafael J. Wysocki
2017-06-30 8:44 ` Mika Westerberg
2017-06-30 16:16 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170609072233.5594-1-kai.heng.feng@canonical.com \
--to=kai.heng.feng@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®