mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Aviya Erenfeld <aviyae42@gmail.com>
Cc: gregkh@linuxfoundation.org, goudapatilk@gmail.com,
	insafonov@gmail.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] staging: rtl8188eu: Shorten lines over 80 chars
Date: Mon, 12 Jun 2017 16:35:57 +0300	[thread overview]
Message-ID: <20170612133557.k6hrnw4yjl4yb4ab@mwanda> (raw)
In-Reply-To: <a87d1402-c749-9a88-8c02-a99b53dc7201@gmail.com>

On Mon, Jun 12, 2017 at 04:16:18PM +0300, Aviya Erenfeld wrote:
> From: Aviya Erenfeld <aviyae42@gmail.com>

No need for this, your email is set up correctly so it works fine as-is.

> 
> Shorten lines over 80 chars
> 
> Signed-off-by: Aviya Erenfeld <aviyae42@gmail.com>
> ---
>  drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 58 +++++++++++++++++++---------
>  1 file changed, 39 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> index cd348ca..c924c9e 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> @@ -68,7 +68,8 @@ u32    _rtw_init_sta_priv(struct    sta_priv *pstapriv)
>      struct sta_info *psta;
>      s32 i;
>  
> -    pstapriv->pallocated_stainfo_buf = vzalloc(sizeof(struct sta_info) * NUM_STA + 4);
> +    pstapriv->pallocated_stainfo_buf = vzalloc(sizeof(struct sta_info) *
> +                           NUM_STA + 4);

None of these are aligned correctly.  Run checkpatch.pl --strict over
your patch.  It should be something like:

	pstapriv->pallocated_stainfo_buf = vzalloc(sizeof(struct sta_info) *
						   NUM_STA + 4);

Also the patch is corrupted and doesn't apply.  Read
Documentation/process/email-clients.rst

regards,
dan carpenter

      reply	other threads:[~2017-06-12 13:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-12 13:11 [PATCH 0/3] staging:rtl8188eu: fix some style issues Aviya Erenfeld
2017-06-12 13:13 ` [PATCH 1/3] staging: rtl8188eu: Remove redundant parenthesis Aviya Erenfeld
2017-06-12 13:14 ` [PATCH 2/3] staging: rtl8188eu: Remove unneeded blank lines Aviya Erenfeld
2017-06-12 13:16 ` [PATCH 3/3] staging: rtl8188eu: Shorten lines over 80 chars Aviya Erenfeld
2017-06-12 13:35   ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170612133557.k6hrnw4yjl4yb4ab@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=aviyae42@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=goudapatilk@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=insafonov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®