From: "Luck, Tony" <tony.luck@intel.com>
To: Yazen Ghannam <Yazen.Ghannam@amd.com>
Cc: linux-edac@vger.kernel.org, Borislav Petkov <bp@suse.de>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/mce: Always save severity in machine_check_poll
Date: Mon, 12 Jun 2017 11:07:54 -0700 [thread overview]
Message-ID: <20170612180753.mjoutdtp3mgpqqvp@intel.com> (raw)
In-Reply-To: <1497286446-59533-1-git-send-email-Yazen.Ghannam@amd.com>
On Mon, Jun 12, 2017 at 11:54:06AM -0500, Yazen Ghannam wrote:
> - severity = mce_severity(&m, mca_cfg.tolerant, NULL, false);
> -
> - if (severity == MCE_DEFERRED_SEVERITY && mce_is_memory_error(&m))
> - if (m.status & MCI_STATUS_ADDRV)
> - m.severity = severity;
> + m.severity = mce_severity(&m, mca_cfg.tolerant, NULL, false);
So that isn't quite the same. Before we only set m.severity for
memory errors where we had a valid address. Now you unconditionally
set it.
Maybe that's more useful. But it now needs an audit of the code
the registered notifiers to make sure they didn't assume that
severity set meant that this is a memory error.
-Tony
next prev parent reply other threads:[~2017-06-12 18:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-12 16:54 Yazen Ghannam
2017-06-12 18:07 ` Luck, Tony [this message]
2017-06-12 18:55 ` Ghannam, Yazen
2017-06-14 14:20 ` Borislav Petkov
2017-06-16 14:49 ` Ghannam, Yazen
2017-06-19 16:48 ` Borislav Petkov
2017-06-21 19:41 ` Ghannam, Yazen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170612180753.mjoutdtp3mgpqqvp@intel.com \
--to=tony.luck@intel.com \
--cc=Yazen.Ghannam@amd.com \
--cc=bp@suse.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®