From: Mark Brown <broonie@kernel.org>
To: John Stultz <john.stultz@linaro.org>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
lkml <linux-kernel@vger.kernel.org>,
Zhangfei Gao <zhangfei.gao@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Wei Xu <xuwei5@hisilicon.com>, Rob Herring <robh+dt@kernel.org>,
Andy Green <andy@warmcat.com>, Dave Long <dave.long@linaro.org>,
Guodong Xu <guodong.xu@linaro.org>,
Antonio Borneo <borneo.antonio@gmail.com>,
Olof Johansson <olof@lixom.net>, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [RESEND x3][PATCH v4] arm64: dts: hi6220: Add k3-dma and i2s/hdmi audio support
Date: Tue, 13 Jun 2017 22:46:48 +0100 [thread overview]
Message-ID: <20170613214648.auh7efw4db5cgwvx@sirena.org.uk> (raw)
In-Reply-To: <CALAqxLVjU3MCZJABWSHLDkHYo_+d9ON9z3ieGkKOBi21vS5J6A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1943 bytes --]
On Tue, Jun 13, 2017 at 01:42:15PM -0700, John Stultz wrote:
> Its a trivial bit of code, but its in the drm directory and I suspect
> at this stage I'm not going to be able to get maintainer attention for
> it in time for 4.13 (plus since it depends on things in the ASoC tree,
> so it needs cross-maintainer acks and probably to go through the ASoC
> tree).
Can I apply it directly? Given that it's all ASoC code it might be the
most expedient way to handle this. It doesn't look like there's any DRM
changes to meaningfully conflict with.
> Plus the new dts changes with the graph need review (where as the
> existing ones have been sent out 5 or so times w/o comment) before
> they are merged. Its just a ton of extra friction that doesn't gain
> much and just keeps functionality from working upstream.
What's happened here is that because you've been sending it for so long
the code around it changed so there's new review comments.
> As for your concern about follow up, I've got the patches lined up here:
> https://git.linaro.org/people/john.stultz/android-dev.git/commit/?h=dev/hikey-mainline-WIP&id=31e8b980d93087cf30cd708fb0b2cc48e906d003
> https://git.linaro.org/people/john.stultz/android-dev.git/commit/?h=dev/hikey-mainline-WIP&id=f24a0ccdeeb46ce3eb8864fd43f7a34c673ff9da
> And will revise and submit the adv7511 one for initial review today.
> So again, I'm happy to migrate over. But I just think, as the graph
> stuff doesn't actually benefit us much in this specific case (there is
> only one supported audio out path right now), its not worth blocking
> getting the functionality working upstream for another 3-6 months.
If it might take two kernel releases to get such a trivial change in
then that's not giving me a warm fuzzy feeling... there's something
not working very well with the HiKey support overall with frequent
process problems (only today I had someone resubmitting already applied
code).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2017-06-13 21:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-12 20:52 John Stultz
2017-06-12 22:10 ` Mark Brown
2017-06-13 0:45 ` John Stultz
2017-06-13 2:09 ` Kuninori Morimoto
2017-06-13 19:40 ` John Stultz
2017-06-13 19:54 ` Mark Brown
2017-06-13 19:57 ` John Stultz
2017-06-13 20:16 ` Mark Brown
2017-06-13 20:42 ` John Stultz
2017-06-13 21:46 ` Mark Brown [this message]
2017-06-13 22:08 ` John Stultz
2017-06-14 14:42 ` Mark Brown
2017-06-14 18:05 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170613214648.auh7efw4db5cgwvx@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andy@warmcat.com \
--cc=arnd@arndb.de \
--cc=borneo.antonio@gmail.com \
--cc=dave.long@linaro.org \
--cc=guodong.xu@linaro.org \
--cc=john.stultz@linaro.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
--cc=xuwei5@hisilicon.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®