From: Steven Rostedt <rostedt@goodmis.org>
To: Michal Hocko <mhocko@kernel.org>
Cc: Vlastimil Babka <vbabka@suse.cz>,
David Rientjes <rientjes@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] oom, trace: Remove ENUM evaluation of COMPACTION_FEEDBACK
Date: Thu, 15 Jun 2017 07:48:13 -0400 [thread overview]
Message-ID: <20170615074813.1ed10a07@gandalf.local.home> (raw)
In-Reply-To: <20170615105720.GH1486@dhcp22.suse.cz>
On Thu, 15 Jun 2017 12:57:21 +0200
Michal Hocko <mhocko@kernel.org> wrote:
> > #define COMPACTION_FEEDBACK \
> > EM(COMPACTION_FAILED, "failed") \
> > EM(COMPACTION_WITHDRAWN, "withdrawn") \
> > EMe(COMPACTION_PROGRESS, "progress")
> >
> > Which is still needed for the __print_symbolic() usage in the
> > trace_event. But it is not needed to be evaluated.
> >
> > Removing the evaluation part removes the unnecessary evaluations of
> > numbers to numbers.
>
> I will be honest with you. Even if I understood how this voodoo mapping
> works I forgot everything. So if the COMPACTION_*->names keeps working
> I have no objection to the patch.
Yes it does. It you want to verify, simply boot the kernel without the
patch and do:
# cat /sys/kernel/debug/tracing/events/*/*/format > ~/formats1
Add the patch, compile and boot that kernel.
# cat /sys/kernel/debug/tracing/events/*/*/format > ~/formats2
then:
# diff formats1 formats2
and they should be the same, with the exception that the ID:'s can
change.
Also, let me send a v2. Resending this patch (from the private one)
seems to broke the format of it.
-- Steve
prev parent reply other threads:[~2017-06-15 11:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-15 10:48 Steven Rostedt
2017-06-15 10:57 ` Michal Hocko
2017-06-15 11:48 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170615074813.1ed10a07@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®