* [PATCH] bridge: Fix panel-bridge error return on !panel.
@ 2017-06-15 17:54 Eric Anholt
2017-06-16 6:02 ` Archit Taneja
0 siblings, 1 reply; 2+ messages in thread
From: Eric Anholt @ 2017-06-15 17:54 UTC (permalink / raw)
To: dri-devel, Archit Taneja, Andrzej Hajda, Laurent Pinchart
Cc: linux-kernel, Eric Anholt
ERR_PTR() needs a negative errno argument.
Signed-off-by: Eric Anholt <eric@anholt.net>
---
drivers/gpu/drm/bridge/panel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
index 99f9a4beb859..67fe19e5a9c6 100644
--- a/drivers/gpu/drm/bridge/panel.c
+++ b/drivers/gpu/drm/bridge/panel.c
@@ -161,7 +161,7 @@ struct drm_bridge *drm_panel_bridge_add(struct drm_panel *panel,
int ret;
if (!panel)
- return ERR_PTR(EINVAL);
+ return ERR_PTR(-EINVAL);
panel_bridge = devm_kzalloc(panel->dev, sizeof(*panel_bridge),
GFP_KERNEL);
--
2.11.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] bridge: Fix panel-bridge error return on !panel.
2017-06-15 17:54 [PATCH] bridge: Fix panel-bridge error return on !panel Eric Anholt
@ 2017-06-16 6:02 ` Archit Taneja
0 siblings, 0 replies; 2+ messages in thread
From: Archit Taneja @ 2017-06-16 6:02 UTC (permalink / raw)
To: Eric Anholt, dri-devel, Andrzej Hajda, Laurent Pinchart; +Cc: linux-kernel
On 06/15/2017 11:24 PM, Eric Anholt wrote:
> ERR_PTR() needs a negative errno argument.
Thanks, I'll queue it to drm-misc-next-fixes once it's opened.
Archit
>
> Signed-off-by: Eric Anholt <eric@anholt.net>
> ---
> drivers/gpu/drm/bridge/panel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
> index 99f9a4beb859..67fe19e5a9c6 100644
> --- a/drivers/gpu/drm/bridge/panel.c
> +++ b/drivers/gpu/drm/bridge/panel.c
> @@ -161,7 +161,7 @@ struct drm_bridge *drm_panel_bridge_add(struct drm_panel *panel,
> int ret;
>
> if (!panel)
> - return ERR_PTR(EINVAL);
> + return ERR_PTR(-EINVAL);
>
> panel_bridge = devm_kzalloc(panel->dev, sizeof(*panel_bridge),
> GFP_KERNEL);
>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-16 6:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-15 17:54 [PATCH] bridge: Fix panel-bridge error return on !panel Eric Anholt
2017-06-16 6:02 ` Archit Taneja
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®