From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Alexander Gerasiov <gq@redlab-i.ru>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] parport_serial: Add support for WCH CH382L PCI-E single parallel port card.
Date: Sun, 18 Jun 2017 22:06:59 +0100 [thread overview]
Message-ID: <20170618210659.GA3785@sudip-laptop> (raw)
In-Reply-To: <20170618213748.28e312c6@brick.gerasiov.net>
On Sun, Jun 18, 2017 at 09:37:48PM +0300, Alexander Gerasiov wrote:
> Hello Andy,
>
> While preparing the update I suddenly found, that parport_serial.c is
> not the right place for this card. Since there is no serial ports on
> the board, it would be better to put it into parport_pc.c
Yes, that will be better. Thanks.
I should have pointed that out but I was confused as I saw MOSCHIP 9900,
which is parallel only, in that file also. But now digging into the past
I found the reason for that.
So, yes, your change should be in parport_pc.c
--
Regards
Sudip
next prev parent reply other threads:[~2017-06-18 21:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-17 13:02 Sudip Mukherjee
2017-06-17 13:45 ` Andy Shevchenko
2017-06-18 18:37 ` Alexander Gerasiov
2017-06-18 21:06 ` Sudip Mukherjee [this message]
2017-06-19 18:37 ` Alan Cox
2017-07-05 11:07 ` Alexander Gerasiov
2017-07-05 20:02 ` [PATCH] parport_pc: " Alexander Gerasiov
2017-07-05 21:28 ` Andy Shevchenko
2018-02-03 23:37 ` Alexander Gerasiov
2018-02-03 23:50 ` Alexander Gerasiov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170618210659.GA3785@sudip-laptop \
--to=sudipm.mukherjee@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=gq@redlab-i.ru \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®