From: Alexander Gerasiov <gq@redlab-i.ru>
To: Alan Cox <gnomes@lxorguk.ukuu.org.uk>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] parport_serial: Add support for WCH CH382L PCI-E single parallel port card.
Date: Wed, 5 Jul 2017 14:07:23 +0300 [thread overview]
Message-ID: <20170705140723.709d9c51@brick.gerasiov.net> (raw)
In-Reply-To: <20170619193734.08f1697f@alans-desktop>
Hello Alan,
On Mon, 19 Jun 2017 19:37:34 +0100
Alan Cox <gnomes@lxorguk.ukuu.org.uk> wrote:
> On Sun, 18 Jun 2017 22:06:59 +0100
> Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote:
>
> > On Sun, Jun 18, 2017 at 09:37:48PM +0300, Alexander Gerasiov
> > wrote:
> > > Hello Andy,
> > >
> > > While preparing the update I suddenly found, that
> > > parport_serial.c is not the right place for this card. Since
> > > there is no serial ports on the board, it would be better to put
> > > it into parport_pc.c
> >
> > Yes, that will be better. Thanks.
>
> Are the uarts physically present but the connector unwired, or are
> they not detectable at all ?
>
> If it's the former then can you add a comment in parport_serial.c
> giving the ID and explaining why it's not present, even if you put
> the code into parport_pc.
According to http://wiki.linuxcnc.org/cgi-bin/wiki.pl?WCH
the chip itself does not differ from one in card with dev-id 3253. So
technically one can solder connectors and use this card as 2serial +
1parallel.
But he could also remove link between pins 62 and 63 and get the board
indentified as 3252.
So, I believe, it would be less confusing (for users) if we do not
create serial devices for this adapter.
--
Best regards,
Alexander Gerasiov
Contacts:
e-mail: gq@cs.msu.su Homepage: http://gerasiov.net Skype: gerasiov
PGP fingerprint: 04B5 9D90 DF7C C2AB CD49 BAEA CA87 E9E8 2AAC 33F1
next prev parent reply other threads:[~2017-07-05 11:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-17 13:02 Sudip Mukherjee
2017-06-17 13:45 ` Andy Shevchenko
2017-06-18 18:37 ` Alexander Gerasiov
2017-06-18 21:06 ` Sudip Mukherjee
2017-06-19 18:37 ` Alan Cox
2017-07-05 11:07 ` Alexander Gerasiov [this message]
2017-07-05 20:02 ` [PATCH] parport_pc: " Alexander Gerasiov
2017-07-05 21:28 ` Andy Shevchenko
2018-02-03 23:37 ` Alexander Gerasiov
2018-02-03 23:50 ` Alexander Gerasiov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170705140723.709d9c51@brick.gerasiov.net \
--to=gq@redlab-i.ru \
--cc=andy.shevchenko@gmail.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®