From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Ziping Chen <techping.chan@gmail.com>
Cc: wens@csie.org, robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH 1/3] ARM: dts: sunxi: add R_LRADC support for A83T
Date: Tue, 20 Jun 2017 10:57:48 +0200 [thread overview]
Message-ID: <20170620085748.apv3wlehyllecb5q@flea.lan> (raw)
In-Reply-To: <20170618130018.10684-1-techping.chan@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1013 bytes --]
On Sun, Jun 18, 2017 at 09:00:16PM +0800, Ziping Chen wrote:
> From: Ziping Chen <techping.chan@gmail.com>
>
> The Allwinner A83T's R_LRADC is similiar with the
> Allwinner A10's LRADC, they can use the same driver.
There's a typo in similar above.
> Add support for it.
>
> Signed-off-by: Ziping Chen <techping.chan@gmail.com>
> ---
> arch/arm/boot/dts/sun8i-a83t.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi
> index 8923ba625b76..ecc75bf6780e 100644
> --- a/arch/arm/boot/dts/sun8i-a83t.dtsi
> +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi
> @@ -301,5 +301,12 @@
> interrupt-controller;
> #interrupt-cells = <3>;
> };
> +
> + r_lradc: lradc@01f03c00 {
> + compatible = "allwinner,sun4i-a10-lradc-keys";
Could you add an A83T specific compatible here?
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
prev parent reply other threads:[~2017-06-20 8:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-18 13:00 Ziping Chen
2017-06-18 13:00 ` [PATCH 2/3] ARM: dts: sunxi: add MMC " Ziping Chen
2017-06-20 9:49 ` Maxime Ripard
2017-06-18 13:00 ` [PATCH 3/3] ARM: dts: sunxi: Add support for Sinlinx SinA83T board Ziping Chen
2017-06-20 8:57 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170620085748.apv3wlehyllecb5q@flea.lan \
--to=maxime.ripard@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=techping.chan@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®