* [PATCH] drivers/fsi: fix fsi_slave_mode prototype
@ 2017-06-20 20:43 Arnd Bergmann
2017-06-21 0:49 ` Jeremy Kerr
2017-07-04 10:29 ` Geert Uytterhoeven
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2017-06-20 20:43 UTC (permalink / raw)
To: Jeremy Kerr
Cc: Arnd Bergmann, Greg Kroah-Hartman, Joel Stanley,
Christopher Bostic, Chris Bostic, linux-kernel
gcc warns about the return type of this function:
drivers/fsi/fsi-core.c:535:8: error: type qualifiers ignored on function return type [-Werror=ignored-qualifiers]
This removes the 'const' attribute, as suggested by the warning.
Fixes: 2b37c3e285f9 ("drivers/fsi: Set slave SMODE to init communication")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/fsi/fsi-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c
index a485864cb512..f2e08932e2d9 100644
--- a/drivers/fsi/fsi-core.c
+++ b/drivers/fsi/fsi-core.c
@@ -532,7 +532,7 @@ static inline uint32_t fsi_smode_sid(int x)
return (x & FSI_SMODE_SID_MASK) << FSI_SMODE_SID_SHIFT;
}
-static const uint32_t fsi_slave_smode(int id)
+static uint32_t fsi_slave_smode(int id)
{
return FSI_SMODE_WSC | FSI_SMODE_ECRC
| fsi_smode_sid(id)
--
2.9.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drivers/fsi: fix fsi_slave_mode prototype
2017-06-20 20:43 [PATCH] drivers/fsi: fix fsi_slave_mode prototype Arnd Bergmann
@ 2017-06-21 0:49 ` Jeremy Kerr
2017-07-04 10:29 ` Geert Uytterhoeven
1 sibling, 0 replies; 3+ messages in thread
From: Jeremy Kerr @ 2017-06-21 0:49 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Greg Kroah-Hartman, Joel Stanley, Christopher Bostic,
Chris Bostic, linux-kernel
Hi Arnd,
> gcc warns about the return type of this function:
>
> drivers/fsi/fsi-core.c:535:8: error: type qualifiers ignored on function return type [-Werror=ignored-qualifiers]
>
> This removes the 'const' attribute, as suggested by the warning.
Acked-by: Jeremy Kerr <jk@ozlabs.org>
Cheers,
Jeremy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/fsi: fix fsi_slave_mode prototype
2017-06-20 20:43 [PATCH] drivers/fsi: fix fsi_slave_mode prototype Arnd Bergmann
2017-06-21 0:49 ` Jeremy Kerr
@ 2017-07-04 10:29 ` Geert Uytterhoeven
1 sibling, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2017-07-04 10:29 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Jeremy Kerr, Greg Kroah-Hartman, Joel Stanley,
Christopher Bostic, Chris Bostic, linux-kernel
On Tue, Jun 20, 2017 at 10:43 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> gcc warns about the return type of this function:
>
> drivers/fsi/fsi-core.c:535:8: error: type qualifiers ignored on function return type [-Werror=ignored-qualifiers]
>
> This removes the 'const' attribute, as suggested by the warning.
>
> Fixes: 2b37c3e285f9 ("drivers/fsi: Set slave SMODE to init communication")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-04 10:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-20 20:43 [PATCH] drivers/fsi: fix fsi_slave_mode prototype Arnd Bergmann
2017-06-21 0:49 ` Jeremy Kerr
2017-07-04 10:29 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®