From: Ingo Molnar <mingo@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Anna-Maria Gleixner <anna-maria@linutronix.de>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rcu: remove unused variable in boot_cpu_state_init
Date: Thu, 22 Jun 2017 09:59:10 +0200 [thread overview]
Message-ID: <20170622075910.mahc5gzrz5cxdsg6@gmail.com> (raw)
In-Reply-To: <20170622075410.pur2m5dobqcwosjh@gmail.com>
So, to continue this side thought about uninitialized_var(), it is dangerous
because the following buggy pattern does not generate a compiler warning:
long uninitialized_var(error);
...
if (error)
return error;
... and still there are over 290 uses of uninitialized_var() in the kernel - and
any of them could turn into a silent but real uninitialized variable bugs due to
subsequent changes.
Thanks,
Ingo
next prev parent reply other threads:[~2017-06-22 7:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 21:57 Arnd Bergmann
2017-06-21 22:10 ` Paul E. McKenney
2017-06-21 22:15 ` Arnd Bergmann
2017-06-22 14:36 ` Paul E. McKenney
2017-06-22 21:10 ` Paul E. McKenney
2017-06-22 7:26 ` Ingo Molnar
2017-06-22 7:41 ` Arnd Bergmann
2017-06-22 7:51 ` Ingo Molnar
2017-06-22 7:54 ` Ingo Molnar
2017-06-22 7:59 ` Ingo Molnar [this message]
2017-06-22 8:58 ` Arnd Bergmann
2017-06-22 9:02 ` Ingo Molnar
2017-06-22 9:44 ` Arnd Bergmann
2017-06-22 14:55 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170622075910.mahc5gzrz5cxdsg6@gmail.com \
--to=mingo@kernel.org \
--cc=anna-maria@linutronix.de \
--cc=arnd@arndb.de \
--cc=bigeasy@linutronix.de \
--cc=boris.ostrovsky@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®