From: Daniel Vetter <daniel@ffwll.ch>
To: Jose Abreu <Jose.Abreu@synopsys.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Carlos Palminha <CARLOS.PALMINHA@synopsys.com>,
Dave Airlie <airlied@linux.ie>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Neil Armstrong <narmstrong@baylibre.com>
Subject: Re: [PATCH v5 05/10] drm: arcpgu: Use crtc->mode_valid() callback
Date: Thu, 22 Jun 2017 10:46:19 +0200 [thread overview]
Message-ID: <20170622084619.buquchxit5aggv6b@phenom.ffwll.local> (raw)
In-Reply-To: <6b270b74-a18d-53ff-81b7-649c7c9411a7@synopsys.com>
On Wed, Jun 21, 2017 at 10:38:43AM +0100, Jose Abreu wrote:
> Hi Daniel, Alexey,
>
>
> On 25-05-2017 15:19, Jose Abreu wrote:
> > Now that we have a callback to check if crtc supports a given mode
> > we can use it in arcpgu so that we restrict the number of probbed
> > modes to the ones we can actually display.
> >
> > This is specially useful because arcpgu crtc is responsible to set
> > a clock value in the commit() stage but unfortunatelly this clock
> > does not support all the needed ranges.
> >
> > Also, remove the atomic_check() callback as mode_valid() callback
> > will be called before.
> >
> > Signed-off-by: Jose Abreu <joabreu@synopsys.com>
> > Reviewed-by: Alexey Brodkin <abrodkin@synopsys.com>
>
> @Daniel: I know that arcpgu is not under drm-misc but could you
> apply this into drm-misc-next? Alexey (the arcpgu maintainer)
> already gave the reviewed-by and this is also "Reviewed-by: Neil
> Armstrong <narmstrong@baylibre.com>". It was also tested-by: me.
>
> @Alexey: Is this ok for you?
>
> I need this because I have a pending patch for accepting clock
> variations instead of always failing when clk_round_rate() does
> not return the expected rate.
Alexey reviewed it already, and Dave acked it for merging through
drm-misc, so applied.
Thanks, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2017-06-22 8:46 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-25 14:19 [PATCH v5 00/10] Introduce new mode validation callbacks Jose Abreu
2017-05-25 14:19 ` [PATCH v5 01/10] drm: Add drm_{crtc/encoder/connector}_mode_valid() Jose Abreu
2017-05-30 6:38 ` Daniel Vetter
2017-05-30 7:26 ` Neil Armstrong
2017-05-25 14:19 ` [PATCH v5 02/10] drm: Introduce drm_bridge_mode_valid() Jose Abreu
2017-05-26 4:25 ` Archit Taneja
2017-05-30 7:27 ` Neil Armstrong
2017-05-25 14:19 ` [PATCH v5 03/10] drm: Use new mode_valid() helpers in connector probe helper Jose Abreu
2017-05-30 7:27 ` Neil Armstrong
2017-05-25 14:19 ` [PATCH v5 04/10] drm: Use mode_valid() in atomic modeset Jose Abreu
2017-05-29 19:38 ` Daniel Vetter
2017-05-30 7:27 ` Neil Armstrong
2017-05-25 14:19 ` [PATCH v5 05/10] drm: arcpgu: Use crtc->mode_valid() callback Jose Abreu
2017-05-30 7:28 ` Neil Armstrong
2017-06-21 9:38 ` Jose Abreu
2017-06-22 8:46 ` Daniel Vetter [this message]
2017-05-25 14:19 ` [PATCH v5 06/10] drm/bridge: analogix-anx78xx: Use bridge->mode_valid() callback Jose Abreu
2017-05-26 4:27 ` Archit Taneja
2017-05-30 7:28 ` Neil Armstrong
2017-05-30 10:35 ` Archit Taneja
2017-05-25 14:19 ` [PATCH v5 07/10] drm/bridge/synopsys: dw-hdmi: " Jose Abreu
2017-05-29 9:45 ` Neil Armstrong
2017-05-30 10:24 ` Archit Taneja
2017-05-30 10:29 ` Philipp Zabel
2017-06-05 7:53 ` Archit Taneja
2017-05-25 14:19 ` [PATCH v5 08/10] drm/arm: malidp: Use crtc->mode_valid() callback Jose Abreu
2017-05-30 7:29 ` Neil Armstrong
2017-05-30 9:37 ` Liviu Dudau
2017-05-31 8:20 ` Daniel Vetter
2017-05-31 10:48 ` Liviu Dudau
2017-05-31 10:56 ` Daniel Vetter
2017-05-31 11:09 ` Liviu Dudau
2017-05-25 14:19 ` [PATCH v5 09/10] drm/atmel-hlcdc: " Jose Abreu
2017-05-30 7:30 ` Neil Armstrong
2017-06-02 9:35 ` Boris Brezillon
2017-05-25 14:19 ` [PATCH v5 10/10] drm: vc4: Use crtc->mode_valid() and encoder->mode_valid() callbacks Jose Abreu
2017-05-30 7:30 ` Neil Armstrong
2017-06-02 20:10 ` Eric Anholt
2017-06-20 8:47 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170622084619.buquchxit5aggv6b@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=Alexey.Brodkin@synopsys.com \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=Jose.Abreu@synopsys.com \
--cc=airlied@linux.ie \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®