mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
	"H . J . Lu" <hjl.tools@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Michal Marek <mmarek@suse.com>,
	x86@kernel.org, linux-kbuild@vger.kernel.org,
	linux-kernel@vger.kernel.org, Michael Davidson <md@google.com>,
	Greg Hackmann <ghackmann@google.com>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Stephen Hines <srhines@google.com>,
	Kees Cook <keescook@chromium.org>, Arnd Bergmann <arnd@arndb.de>,
	Bernhard.Rosenkranzer@linaro.org,
	Peter Foley <pefoley2@pefoley.com>,
	Behan Webster <behanw@converseincode.com>,
	Douglas Anderson <dianders@chromium.org>
Subject: Re: [PATCH v5 0/3] x86: stack alignment for boot code and clang
Date: Thu, 22 Jun 2017 10:58:48 +0200	[thread overview]
Message-ID: <20170622085848.kot52wfxsntruoaz@gmail.com> (raw)
In-Reply-To: <20170621232805.149448-1-mka@chromium.org>


* Matthias Kaehlcke <mka@chromium.org> wrote:

> This series fixes an issue with the stack of the x86 boot code not
> being aligned as intended. Further it adapts the Makefile to account
> for the fact that clang uses a different option to configure the
> stack alignment than gcc (-mstack-alignment=N vs
> -mpreferred-stack-boundary=N)
> 
> Collaterally the series adds the new kbuild macro __cc-option and
> refactors the macros cc-option and hostcc-option to make use of
> __cc-option.
> 
> Matthias Kaehlcke (3):
>   kbuild: Add __cc-option macro
>   x86/build: Use __cc-option for boot code compiler options
>   x86/build: Specify stack alignment for clang
> 
>  Makefile               |  2 +-
>  arch/x86/Makefile      | 33 +++++++++++++++++++++++++--------
>  scripts/Kbuild.include | 14 ++++++++++++--
>  scripts/Makefile.host  |  6 ------
>  4 files changed, 38 insertions(+), 17 deletions(-)

So given that there are non-trivial kbuild changes here, I'd suggest these patches 
might have a better home in the kbuild tree. For the x86 bits:

Acked-by: Ingo Molnar <mingo@kernel.org>

Thanks,

	Ingo

  parent reply	other threads:[~2017-06-22  8:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-21 23:28 Matthias Kaehlcke
2017-06-21 23:28 ` [PATCH v5 1/3] kbuild: Add __cc-option macro Matthias Kaehlcke
2017-06-21 23:28 ` [PATCH v5 2/3] x86/build: Use __cc-option for boot code compiler options Matthias Kaehlcke
2017-06-21 23:28 ` [PATCH v5 3/3] x86/build: Specify stack alignment for clang Matthias Kaehlcke
2017-06-25  4:05   ` Masahiro Yamada
2017-06-22  8:58 ` Ingo Molnar [this message]
2017-06-25  4:04   ` [PATCH v5 0/3] x86: stack alignment for boot code and clang Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170622085848.kot52wfxsntruoaz@gmail.com \
    --to=mingo@kernel.org \
    --cc=Bernhard.Rosenkranzer@linaro.org \
    --cc=arnd@arndb.de \
    --cc=behanw@converseincode.com \
    --cc=dianders@chromium.org \
    --cc=dwmw2@infradead.org \
    --cc=ghackmann@google.com \
    --cc=hjl.tools@gmail.com \
    --cc=hpa@zytor.com \
    --cc=keescook@chromium.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=md@google.com \
    --cc=mingo@redhat.com \
    --cc=mka@chromium.org \
    --cc=mmarek@suse.com \
    --cc=ndesaulniers@google.com \
    --cc=pefoley2@pefoley.com \
    --cc=srhines@google.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®