From: "Theodore Ts'o" <tytso@mit.edu>
To: Tahsin Erdogan <tahsin@google.com>
Cc: Andreas Dilger <adilger@dilger.ca>,
"Darrick J . Wong" <darrick.wong@oracle.com>,
Jan Kara <jack@suse.cz>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 31/32] ext4: strong binding of xattr inode references
Date: Thu, 22 Jun 2017 11:54:24 -0400 [thread overview]
Message-ID: <20170622155424.jj6c3fglp3vehddq@thunk.org> (raw)
In-Reply-To: <20170622014939.3592-8-tahsin@google.com>
On Wed, Jun 21, 2017 at 06:49:38PM -0700, Tahsin Erdogan wrote:
> To verify that a xattr entry is not pointing to the wrong xattr inode,
> we currently check that the target inode has EXT4_EA_INODE_FL flag set and
> also the entry size matches the target inode size.
>
> For stronger validation, also incorporate crc32c hash of the value into
> the e_hash field. This is done regardless of whether the entry lives in
> the inode body or external attribute block.
>
> Signed-off-by: Tahsin Erdogan <tahsin@google.com>
Added to the ext4 patch queue, thanks.
- Ted
next prev parent reply other threads:[~2017-06-22 15:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-22 1:49 [PATCH 24/32] ext2, ext4: make mb block cache names more explicit Tahsin Erdogan
2017-06-22 1:49 ` [PATCH 25/32] ext4: add ext4_is_quota_file() Tahsin Erdogan
2017-06-22 15:39 ` Theodore Ts'o
2017-06-22 1:49 ` [PATCH 26/32] ext4: cleanup transaction restarts during inode deletion Tahsin Erdogan
2017-06-22 15:43 ` Theodore Ts'o
2017-06-22 1:49 ` [PATCH 27/32] ext4: xattr inode deduplication Tahsin Erdogan
2017-06-22 15:45 ` Theodore Ts'o
2017-06-22 1:49 ` [PATCH 28/32] quota: add get_inode_usage callback to transfer multi-inode charges Tahsin Erdogan
2017-06-22 15:47 ` Theodore Ts'o
2017-06-22 1:49 ` [PATCH 29/32] ext4: reserve space for xattr entries/names Tahsin Erdogan
2017-06-22 15:49 ` Theodore Ts'o
2017-06-22 1:49 ` [PATCH 30/32] ext4: eliminate xattr entry e_hash recalculation for removes Tahsin Erdogan
2017-06-22 15:52 ` Theodore Ts'o
2017-06-22 1:49 ` [PATCH 31/32] ext4: strong binding of xattr inode references Tahsin Erdogan
2017-06-22 15:54 ` Theodore Ts'o [this message]
2017-06-22 1:49 ` [PATCH 32/32] ext4: add nombcache mount option Tahsin Erdogan
2017-06-22 16:00 ` Theodore Ts'o
2017-06-22 15:30 ` [PATCH 24/32] ext2, ext4: make mb block cache names more explicit Theodore Ts'o
-- strict thread matches above, loose matches on Subject: below --
2017-06-21 21:21 [PATCH 01/32] ext4: xattr-in-inode support Tahsin Erdogan
2017-06-21 21:21 ` [PATCH 31/32] ext4: strong binding of xattr inode references Tahsin Erdogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170622155424.jj6c3fglp3vehddq@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=darrick.wong@oracle.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tahsin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®