* [PATCH v2] sparc64: Fix gup_huge_pmd
@ 2017-06-23 0:15 Nitin Gupta
2017-06-25 19:24 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Nitin Gupta @ 2017-06-23 0:15 UTC (permalink / raw)
To: David S. Miller
Cc: Julian Calaby, David S. Miller, Nitin Gupta, Lorenzo Stoakes,
Jan Kara, Michal Hocko, sparclinux, linux-kernel
The function assumes that each PMD points to head of a
huge page. This is not correct as a PMD can point to
start of any 8M region with a, say 256M, hugepage. The
fix ensures that it points to the correct head of any PMD
huge page.
Cc: Julian Calaby <julian.calaby@gmail.com>
Signed-off-by: Nitin Gupta <nitin.m.gupta@oracle.com>
---
Changes since v1
- Clarify use of 'head' variable (Julian Calaby)
arch/sparc/mm/gup.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/sparc/mm/gup.c b/arch/sparc/mm/gup.c
index cd0e32b..f80cfc6 100644
--- a/arch/sparc/mm/gup.c
+++ b/arch/sparc/mm/gup.c
@@ -78,8 +78,8 @@ static int gup_huge_pmd(pmd_t *pmdp, pmd_t pmd, unsigned long addr,
return 0;
refs = 0;
- head = pmd_page(pmd);
- page = head + ((addr & ~PMD_MASK) >> PAGE_SHIFT);
+ page = pmd_page(pmd) + ((addr & ~PMD_MASK) >> PAGE_SHIFT);
+ head = compound_head(page);
do {
VM_BUG_ON(compound_head(page) != head);
pages[*nr] = page;
--
2.9.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v2] sparc64: Fix gup_huge_pmd
2017-06-23 0:15 [PATCH v2] sparc64: Fix gup_huge_pmd Nitin Gupta
@ 2017-06-25 19:24 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-06-25 19:24 UTC (permalink / raw)
To: nitin.m.gupta
Cc: julian.calaby, lstoakes, jack, mhocko, sparclinux, linux-kernel
From: Nitin Gupta <nitin.m.gupta@oracle.com>
Date: Thu, 22 Jun 2017 17:15:08 -0700
> The function assumes that each PMD points to head of a
> huge page. This is not correct as a PMD can point to
> start of any 8M region with a, say 256M, hugepage. The
> fix ensures that it points to the correct head of any PMD
> huge page.
>
> Cc: Julian Calaby <julian.calaby@gmail.com>
> Signed-off-by: Nitin Gupta <nitin.m.gupta@oracle.com>
> ---
> Changes since v1
> - Clarify use of 'head' variable (Julian Calaby)
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-25 19:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-23 0:15 [PATCH v2] sparc64: Fix gup_huge_pmd Nitin Gupta
2017-06-25 19:24 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®