mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* Re: [PATCH] xfs: fix semicolon.cocci warnings
  2017-06-26 15:57 ` [PATCH] xfs: fix semicolon.cocci warnings kbuild test robot
@ 2017-06-26 15:52   ` Brian Foster
  2017-06-26 15:54   ` Darrick J. Wong
  1 sibling, 0 replies; 3+ messages in thread
From: Brian Foster @ 2017-06-26 15:52 UTC (permalink / raw)
  To: kbuild test robot; +Cc: kbuild-all, Darrick J. Wong, linux-xfs, linux-kernel

On Mon, Jun 26, 2017 at 11:57:44PM +0800, kbuild test robot wrote:
> fs/xfs/xfs_log.c:2092:38-39: Unneeded semicolon
> 
> 
>  Remove unneeded semicolon.
> 
> Generated by: scripts/coccinelle/misc/semicolon.cocci
> 
> Fixes: d4ca1d550d05 ("xfs: dump transaction usage details on log reservation overrun")
> CC: Brian Foster <bfoster@redhat.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---

Reviewed-by: Brian Foster <bfoster@redhat.com>

> 
>  xfs_log.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/fs/xfs/xfs_log.c
> +++ b/fs/xfs/xfs_log.c
> @@ -2089,7 +2089,7 @@ xlog_print_trans(
>  			xfs_warn(mp, "    type	= 0x%x", vec->i_type);
>  			xfs_warn(mp, "    len	= %d", vec->i_len);
>  			xfs_warn(mp, "    first %d bytes of iovec[%d]:", dumplen, i);
> -			xfs_hex_dump(vec->i_addr, dumplen);;
> +			xfs_hex_dump(vec->i_addr, dumplen);
>  
>  			vec++;
>  		}
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] xfs: fix semicolon.cocci warnings
  2017-06-26 15:57 ` [PATCH] xfs: fix semicolon.cocci warnings kbuild test robot
  2017-06-26 15:52   ` Brian Foster
@ 2017-06-26 15:54   ` Darrick J. Wong
  1 sibling, 0 replies; 3+ messages in thread
From: Darrick J. Wong @ 2017-06-26 15:54 UTC (permalink / raw)
  To: kbuild test robot; +Cc: Brian Foster, kbuild-all, linux-xfs, linux-kernel

On Mon, Jun 26, 2017 at 11:57:44PM +0800, kbuild test robot wrote:
> fs/xfs/xfs_log.c:2092:38-39: Unneeded semicolon
> 
> 
>  Remove unneeded semicolon.
> 
> Generated by: scripts/coccinelle/misc/semicolon.cocci
> 
> Fixes: d4ca1d550d05 ("xfs: dump transaction usage details on log reservation overrun")
> CC: Brian Foster <bfoster@redhat.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Looks good, will test...
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
> 
>  xfs_log.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/fs/xfs/xfs_log.c
> +++ b/fs/xfs/xfs_log.c
> @@ -2089,7 +2089,7 @@ xlog_print_trans(
>  			xfs_warn(mp, "    type	= 0x%x", vec->i_type);
>  			xfs_warn(mp, "    len	= %d", vec->i_len);
>  			xfs_warn(mp, "    first %d bytes of iovec[%d]:", dumplen, i);
> -			xfs_hex_dump(vec->i_addr, dumplen);;
> +			xfs_hex_dump(vec->i_addr, dumplen);
>  
>  			vec++;
>  		}
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] xfs: fix semicolon.cocci warnings
       [not found] <201706262342.mc5rV25t%fengguang.wu@intel.com>
@ 2017-06-26 15:57 ` kbuild test robot
  2017-06-26 15:52   ` Brian Foster
  2017-06-26 15:54   ` Darrick J. Wong
  0 siblings, 2 replies; 3+ messages in thread
From: kbuild test robot @ 2017-06-26 15:57 UTC (permalink / raw)
  To: Brian Foster; +Cc: kbuild-all, Darrick J. Wong, linux-xfs, linux-kernel

fs/xfs/xfs_log.c:2092:38-39: Unneeded semicolon


 Remove unneeded semicolon.

Generated by: scripts/coccinelle/misc/semicolon.cocci

Fixes: d4ca1d550d05 ("xfs: dump transaction usage details on log reservation overrun")
CC: Brian Foster <bfoster@redhat.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 xfs_log.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/fs/xfs/xfs_log.c
+++ b/fs/xfs/xfs_log.c
@@ -2089,7 +2089,7 @@ xlog_print_trans(
 			xfs_warn(mp, "    type	= 0x%x", vec->i_type);
 			xfs_warn(mp, "    len	= %d", vec->i_len);
 			xfs_warn(mp, "    first %d bytes of iovec[%d]:", dumplen, i);
-			xfs_hex_dump(vec->i_addr, dumplen);;
+			xfs_hex_dump(vec->i_addr, dumplen);
 
 			vec++;
 		}

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-06-26 15:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <201706262342.mc5rV25t%fengguang.wu@intel.com>
2017-06-26 15:57 ` [PATCH] xfs: fix semicolon.cocci warnings kbuild test robot
2017-06-26 15:52   ` Brian Foster
2017-06-26 15:54   ` Darrick J. Wong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®