From: Benson Leung <bleung@google.com>
To: Thierry Escande <thierry.escande@collabora.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Benson Leung <bleung@chromium.org>,
linux-kernel@vger.kernel.org, enric.balletbo@collabora.com
Subject: Re: [PATCH v2 2/3] cros_ec: Fix deadlock when EC is not responsive at probe
Date: Tue, 27 Jun 2017 08:36:12 -0700 [thread overview]
Message-ID: <20170627153612.GB39605@decatoncale.mtv.corp.google.com> (raw)
In-Reply-To: <1487102282-12259-3-git-send-email-thierry.escande@collabora.com>
[-- Attachment #1: Type: text/plain, Size: 833 bytes --]
Hi Thierry,
On Tue, Feb 14, 2017 at 08:58:01PM +0100, Thierry Escande wrote:
> From: Gwendal Grignou <gwendal@chromium.org>
>
> When the EC is not responsive at probe, we try to get basic information
> (protocol to use) later on through cros_xfer_cmd() call.
> This patch makes sure there is no deadlock when re-probing the EC by
> replacing call to cros_xfer_cmd() with send_command() in the function
> cros_ec_get_host_command_version_mask(). Also, this patch adds the
> function header indicating it must be called protected.
>
> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
> Signed-off-by: Thierry Escande <thierry.escande@collabora.com>
Applied. Thanks again!
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2017-06-27 15:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 19:57 [PATCH v2 0/3] mfd: cros_ec: non-wake host events support Thierry Escande
2017-02-14 19:58 ` [PATCH v2 1/3] cros_ec: Don't return error when checking command version Thierry Escande
2017-06-27 15:35 ` Benson Leung
2017-02-14 19:58 ` [PATCH v2 2/3] cros_ec: Fix deadlock when EC is not responsive at probe Thierry Escande
2017-06-27 15:36 ` Benson Leung [this message]
2017-02-14 19:58 ` [PATCH v2 3/3] cros_ec: Don't signal wake event for non-wake host events Thierry Escande
2017-03-14 13:56 ` Lee Jones
2017-06-27 16:23 ` Benson Leung
2017-07-03 11:46 ` Lee Jones
2017-07-05 20:11 ` Benson Leung
2017-07-06 7:12 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170627153612.GB39605@decatoncale.mtv.corp.google.com \
--to=bleung@google.com \
--cc=bleung@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thierry.escande@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®