mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Benson Leung <bleung@google.com>
Cc: Thierry Escande <thierry.escande@collabora.com>,
	Benson Leung <bleung@chromium.org>,
	linux-kernel@vger.kernel.org, enric.balletbo@collabora.com
Subject: Re: [PATCH v2 3/3] cros_ec: Don't signal wake event for non-wake host events
Date: Mon, 3 Jul 2017 12:46:41 +0100	[thread overview]
Message-ID: <20170703114641.2zivoeqiv7tk4bqu@dell> (raw)
In-Reply-To: <20170627162353.GC39605@decatoncale.mtv.corp.google.com>

On Tue, 27 Jun 2017, Benson Leung wrote:

> Hi Thierry,
> 
> On Tue, Feb 14, 2017 at 08:58:02PM +0100, Thierry Escande wrote:
> > From: Shawn Nematbakhsh <shawnn@chromium.org>
> > 
> > The subset of wake-enabled host events is defined by the EC, but the EC
> > may still send non-wake host events if we're in the process of
> > suspending. Get the mask of wake-enabled host events from the EC and
> > filter out non-wake events to prevent spurious aborted suspend
> > attempts.
> > 
> > Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org>
> > Signed-off-by: Thierry Escande <thierry.escande@collabora.com>
> > ---
> >  drivers/mfd/cros_ec.c                   | 13 ++++--
> >  drivers/platform/chrome/cros_ec_proto.c | 76 ++++++++++++++++++++++++++++++---
> >  include/linux/mfd/cros_ec.h             |  5 ++-
> >  3 files changed, 85 insertions(+), 9 deletions(-)
> > 
> 
> Another use of cros_ec_get_next_event was introduced in cros_ec_lpc.c since
> this patch was posted, so I went ahead and modified that too.
> 
> Applied. Thanks.

No need to change anything this time, but please note the "for my own
reference" in my Ack in future.  It typically means that I plan on
pushing it through the MFD tree or that it requires further discussion
(in the case that another Maintainer would prefer it go through their
tree).

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2017-07-03 11:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-14 19:57 [PATCH v2 0/3] mfd: cros_ec: non-wake host events support Thierry Escande
2017-02-14 19:58 ` [PATCH v2 1/3] cros_ec: Don't return error when checking command version Thierry Escande
2017-06-27 15:35   ` Benson Leung
2017-02-14 19:58 ` [PATCH v2 2/3] cros_ec: Fix deadlock when EC is not responsive at probe Thierry Escande
2017-06-27 15:36   ` Benson Leung
2017-02-14 19:58 ` [PATCH v2 3/3] cros_ec: Don't signal wake event for non-wake host events Thierry Escande
2017-03-14 13:56   ` Lee Jones
2017-06-27 16:23   ` Benson Leung
2017-07-03 11:46     ` Lee Jones [this message]
2017-07-05 20:11       ` Benson Leung
2017-07-06  7:12         ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170703114641.2zivoeqiv7tk4bqu@dell \
    --to=lee.jones@linaro.org \
    --cc=bleung@chromium.org \
    --cc=bleung@google.com \
    --cc=enric.balletbo@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thierry.escande@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®