From: David Miller <davem@davemloft.net>
To: clabbe.montjoie@gmail.com
Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk,
maxime.ripard@free-electrons.com, wens@csie.org,
peppe.cavallaro@st.com, alexandre.torgue@st.com,
andre.przywara@arm.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-sunxi@googlegroups.com
Subject: Re: [PATCH 1/6] net: stmmac: support future possible different internal phy mode
Date: Thu, 29 Jun 2017 16:05:13 -0400 (EDT) [thread overview]
Message-ID: <20170629.160513.1064622973584891732.davem@davemloft.net> (raw)
In-Reply-To: <20170629170238.GA2606@Red>
From: Corentin Labbe <clabbe.montjoie@gmail.com>
Date: Thu, 29 Jun 2017 19:02:38 +0200
> On Thu, Jun 29, 2017 at 12:23:49PM -0400, David Miller wrote:
>> From: Corentin Labbe <clabbe.montjoie@gmail.com>
>> Date: Tue, 27 Jun 2017 11:28:01 +0200
>>
>> > The current way to find if the phy is internal is to compare DT phy-mode
>> > and emac_variant/internal_phy.
>> > But it will negate a possible future SoC where an external PHY use the
>> > same phy mode than the internal one.
>> >
>> > By using phy-mode = "internal" we permit to have an external PHY with
>> > the same mode than the internal one.
>> >
>> > Reported-by: André Przywara <andre.przywara@arm.com>
>> > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
>>
>> Series applied.
>>
>> Please provide a proper "[PATCH 0/n] " header posting next time.
>
> Sorry could you wait for applying, there are a parallel thread (http://www.spinics.net/lists/devicetree/msg183520.html) and it seems finaly that internal could not be the good way to do it.
>
> Regards
> Sorry again, I should have sent a comment for waiting.
Please send me a revert patch, when I say I've applied it I already pushed
it out to my GIT tree.
prev parent reply other threads:[~2017-06-29 20:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-27 9:28 Corentin Labbe
2017-06-27 9:28 ` [PATCH 2/6] arm: sun8i: orangepipc: use internal phy-mode Corentin Labbe
2017-06-27 9:28 ` [PATCH 3/6] arm: sun8i: orangepi-zero: " Corentin Labbe
2017-06-27 9:28 ` [PATCH 4/6] arm: sun8i: orangepi-one: " Corentin Labbe
2017-06-27 9:28 ` [PATCH 5/6] arm: sun8i: nanopi-neo: " Corentin Labbe
2017-06-27 9:28 ` [PATCH 6/6] arm: sun8i: orangepi-2: " Corentin Labbe
2017-06-29 16:23 ` [PATCH 1/6] net: stmmac: support future possible different internal phy mode David Miller
2017-06-29 16:46 ` [linux-sunxi] " icenowy
2017-06-29 17:02 ` Corentin Labbe
2017-06-29 20:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170629.160513.1064622973584891732.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexandre.torgue@st.com \
--cc=andre.przywara@arm.com \
--cc=clabbe.montjoie@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®