From: icenowy@aosc.io
To: davem@davemloft.net
Cc: clabbe.montjoie@gmail.com, robh+dt@kernel.org,
mark.rutland@arm.com, linux@armlinux.org.uk,
maxime.ripard@free-electrons.com, wens@csie.org,
peppe.cavallaro@st.com, alexandre.torgue@st.com,
andre.przywara@arm.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-sunxi@googlegroups.com
Subject: Re: [linux-sunxi] Re: [PATCH 1/6] net: stmmac: support future possible different internal phy mode
Date: Fri, 30 Jun 2017 00:46:30 +0800 [thread overview]
Message-ID: <9f1992d1cab37e5f309c6260985ce32a@aosc.io> (raw)
In-Reply-To: <20170629.122349.2265868886957558079.davem@davemloft.net>
在 2017-06-30 00:23，David Miller 写道：
> From: Corentin Labbe <clabbe.montjoie@gmail.com>
> Date: Tue, 27 Jun 2017 11:28:01 +0200
>
>> The current way to find if the phy is internal is to compare DT
>> phy-mode
>> and emac_variant/internal_phy.
>> But it will negate a possible future SoC where an external PHY use the
>> same phy mode than the internal one.
>>
>> By using phy-mode = "internal" we permit to have an external PHY with
>> the same mode than the internal one.
>>
>> Reported-by: André Przywara <andre.przywara@arm.com>
>> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
>
> Series applied.
I think there's still some problems around for this patchset...
The definition of "internal" is internal *proprietary* PHY, but the
internal PHY of Allwinner SoCs seem to be MII...
See [1].
[1]
http://lists.infradead.org/pipermail/linux-arm-kernel/2017-June/516159.html
>
> Please provide a proper "[PATCH 0/n] " header posting next time.
next prev parent reply other threads:[~2017-06-29 16:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-27 9:28 Corentin Labbe
2017-06-27 9:28 ` [PATCH 2/6] arm: sun8i: orangepipc: use internal phy-mode Corentin Labbe
2017-06-27 9:28 ` [PATCH 3/6] arm: sun8i: orangepi-zero: " Corentin Labbe
2017-06-27 9:28 ` [PATCH 4/6] arm: sun8i: orangepi-one: " Corentin Labbe
2017-06-27 9:28 ` [PATCH 5/6] arm: sun8i: nanopi-neo: " Corentin Labbe
2017-06-27 9:28 ` [PATCH 6/6] arm: sun8i: orangepi-2: " Corentin Labbe
2017-06-29 16:23 ` [PATCH 1/6] net: stmmac: support future possible different internal phy mode David Miller
2017-06-29 16:46 ` icenowy [this message]
2017-06-29 17:02 ` Corentin Labbe
2017-06-29 20:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f1992d1cab37e5f309c6260985ce32a@aosc.io \
--to=icenowy@aosc.io \
--cc=alexandre.torgue@st.com \
--cc=andre.przywara@arm.com \
--cc=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®