From: Steven Rostedt <rostedt@goodmis.org>
To: Richard Guy Briggs <rgb@redhat.com>
Cc: Paul Moore <paul@paul-moore.com>,
linux-kernel@vger.kernel.org, linux-audit@redhat.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ingo Molnar <mingo@redhat.com>, Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH ALT4 V2 1/2] audit: show fstype:pathname for entries with anonymous parents
Date: Thu, 29 Jun 2017 19:58:17 -0400 [thread overview]
Message-ID: <20170629195817.4ea4906e@gandalf.local.home> (raw)
In-Reply-To: <20170629212122.GG27193@madcap2.tricolour.ca>
On Thu, 29 Jun 2017 17:21:22 -0400
Richard Guy Briggs <rgb@redhat.com> wrote:
> > Looking at this again today, why would we want to clear name->dentry
> > in audit_copy_inode() if it is already set? Does that ever happen?
> > I'm not sure it does ...
>
> It has been nearly 3 months since I coded that, so I'll have to dive in
> and re-analyse what I was thinking at that time. I think that rationale
> was that if audit_copy_inode() is called again on that audit_name struct
> that it could be called by audit_log_link_denied() or __audit_inode()
> not needing the dentry reference or even by __audit_inode_child() and
> have it replaced, needing a reference count correction.
>
Just a note. If after 3 months you need to re-analyze, you either need
to design things simpler, or have better comments in the code.
-- Steve
next prev parent reply other threads:[~2017-06-29 23:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 9:21 Richard Guy Briggs
2017-04-04 9:21 ` [PATCH ALT4 V2 2/2] audit: filter PATH records keyed on filesystem magic Richard Guy Briggs
2017-04-04 10:02 ` Richard Guy Briggs
2017-05-30 21:30 ` Paul Moore
2017-06-27 20:45 ` Richard Guy Briggs
2017-06-28 19:08 ` Paul Moore
2017-06-28 21:25 ` Richard Guy Briggs
2017-04-04 21:19 ` [PATCH ALT4 V2 1/2] audit: show fstype:pathname for entries with anonymous parents Paul Moore
2017-04-05 4:18 ` Richard Guy Briggs
2017-05-30 21:21 ` Paul Moore
2017-06-27 21:11 ` Richard Guy Briggs
2017-06-28 19:03 ` Paul Moore
2017-06-29 21:21 ` Richard Guy Briggs
2017-06-29 23:58 ` Steven Rostedt [this message]
2017-06-30 13:07 ` Richard Guy Briggs
2017-08-11 6:36 ` Richard Guy Briggs
2017-08-14 4:32 ` Richard Guy Briggs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170629195817.4ea4906e@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paul@paul-moore.com \
--cc=rgb@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®