From: Masami Hiramatsu <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kselftest@vger.kernel.org, shuah@kernel.org,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, naresh.kamboju@linaro.org
Subject: Re: [PATCH 1/2] selftests: ftrace: Do not failure if there is unsupported tests
Date: Tue, 4 Jul 2017 09:30:06 +0900 [thread overview]
Message-ID: <20170704093006.a4c82ae49fe1660f7e19e075@kernel.org> (raw)
In-Reply-To: <20170703115906.6f3b1679@gandalf.local.home>
On Mon, 3 Jul 2017 11:59:06 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Tue, 4 Jul 2017 00:52:32 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
> >
> > >
> > > Can we add an option in kselftest, or to ftracetest that decides if
> > > unsupported is a failure or not? Otherwise I can not ack this patch.
> >
> > I would rather like to add an option to ftracetest instead of
> > kselftest, because whether the tested feature should be supported
> > or not is hard to decide from testing framework. It should be
> > checked by manual.
>
> Can we do both? That is, add an option to have ftracetest not fail on
> "unsupported" but have it fail by default. We can have kselftest just
> pass in a parameter to ftracetest that has unsupported not fail?
I rather like to treat unsupported as success (or XFAIL) by default
and add "--fail-unsupported" option.
Thank you,
> But if that is too difficult, then I can live with modifying my test
> case to add the option.
>
> -- Steve
--
Masami Hiramatsu <mhiramat@kernel.org>
prev parent reply other threads:[~2017-07-04 0:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-03 5:25 Masami Hiramatsu
2017-07-03 5:26 ` [PATCH 2/2] selftests: ftrace: Add more verbosity for immediate log Masami Hiramatsu
2017-07-03 13:19 ` Steven Rostedt
2017-07-03 15:57 ` Masami Hiramatsu
2017-07-03 13:15 ` [PATCH 1/2] selftests: ftrace: Do not failure if there is unsupported tests Steven Rostedt
2017-07-03 15:52 ` Masami Hiramatsu
2017-07-03 15:59 ` Steven Rostedt
2017-07-04 0:30 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170704093006.a4c82ae49fe1660f7e19e075@kernel.org \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=naresh.kamboju@linaro.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome