From: Peter Zijlstra <peterz@infradead.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Kees Cook <keescook@chromium.org>, Ingo Molnar <mingo@kernel.org>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
Thomas Hellstrom <thellstrom@vmware.com>,
Andi Kleen <ak@linux.intel.com>,
Daniel Micay <danielmicay@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kref: Avoid null pointer dereference after WARN
Date: Wed, 5 Jul 2017 17:37:25 +0200 [thread overview]
Message-ID: <20170705153725.4nmdezykcz3b7ped@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20170627070626.GH29909@kroah.com>
On Tue, Jun 27, 2017 at 09:06:26AM +0200, Greg Kroah-Hartman wrote:
>
> I remember one complaint was that WARN_ON was "huge" and this bloated
> the kernel code a lot. But then that got fixed up. Is BUG_ON going to
> cause the same complaint again?
BUG_ON and WARN_ON should be of equal (small) size.
next prev parent reply other threads:[~2017-07-05 15:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-27 3:52 Kees Cook
2017-06-27 7:06 ` Greg Kroah-Hartman
2017-06-27 11:00 ` Jason A. Donenfeld
2017-06-27 14:49 ` Andi Kleen
2017-06-27 19:11 ` Jason A. Donenfeld
2017-06-27 19:29 ` Andi Kleen
2017-06-28 11:26 ` Michal Hocko
2017-06-27 18:34 ` Kees Cook
2017-07-05 15:37 ` Peter Zijlstra [this message]
2017-06-28 11:57 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170705153725.4nmdezykcz3b7ped@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Jason@zx2c4.com \
--cc=ak@linux.intel.com \
--cc=danielmicay@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=thellstrom@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®