From: Masami Hiramatsu <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kselftest@vger.kernel.org, shuah@kernel.org,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, naresh.kamboju@linaro.org
Subject: Re: [PATCH 4/4] selftests: ftrace: Output only to console with "--logdir -"
Date: Thu, 6 Jul 2017 15:00:54 +0900 [thread overview]
Message-ID: <20170706150054.5706d4f2df3763dbb1d65320@kernel.org> (raw)
In-Reply-To: <20170705122917.03346f2d@gandalf.local.home>
On Wed, 5 Jul 2017 12:29:17 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Wed, 5 Jul 2017 12:25:06 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
>
>
> > > @@ -255,12 +262,18 @@ __run_test() { # testfile
> > > # Run one test case
> > > run_test() { # testfile
> > > local testname=`basename $1`
> > > - local testlog=`mktemp $LOG_DIR/${testname}-log.XXXXXX`
> > > + if [ "$LOG_FILE" ] ; then
> >
> > Shouldn't this be
> >
> > if [ ! -z "$LOG_FILE" ]; then
> >
> > ?
> >
>
> OK, I just checked it out. I guess "" is considered zero and
> "<anything>" is considered 1.
>
> Hmm, do we do this in other places too. Just makes me unconfortable.
OK, in that case, I can cleanup the code with [ ! -z "$VAR" ]
Thank you,
>
> -- Steve
>
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2017-07-06 6:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-04 6:34 [PATCH 0/4] selftests: ftrace: ftracetest improvements Masami Hiramatsu
2017-07-04 6:35 ` [PATCH 1/4] selftests: ftrace: Do not failure if there is unsupported tests Masami Hiramatsu
2017-07-04 6:36 ` [PATCH 2/4] selftests: ftrace: Add --fail-unsupported option Masami Hiramatsu
2017-07-04 6:37 ` [PATCH 3/4] selftests: ftrace: Add more verbosity for immediate log Masami Hiramatsu
2017-07-04 6:38 ` [PATCH 4/4] selftests: ftrace: Output only to console with "--logdir -" Masami Hiramatsu
2017-07-05 16:25 ` Steven Rostedt
2017-07-05 16:29 ` Steven Rostedt
2017-07-06 6:00 ` Masami Hiramatsu [this message]
2017-07-06 13:06 ` Stafford Horne
2017-07-06 13:18 ` Steven Rostedt
2017-07-07 0:43 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170706150054.5706d4f2df3763dbb1d65320@kernel.org \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=naresh.kamboju@linaro.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome