From: Masami Hiramatsu <mhiramat@kernel.org>
To: Stafford Horne <shorne@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
linux-kselftest@vger.kernel.org, shuah@kernel.org,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, naresh.kamboju@linaro.org
Subject: Re: [PATCH 4/4] selftests: ftrace: Output only to console with "--logdir -"
Date: Fri, 7 Jul 2017 09:43:39 +0900 [thread overview]
Message-ID: <20170707094339.49d57164003f662162dad9cf@kernel.org> (raw)
In-Reply-To: <20170706130658.GC2511@lianli.shorne-pla.net>
On Thu, 6 Jul 2017 22:06:58 +0900
Stafford Horne <shorne@gmail.com> wrote:
> On Wed, Jul 05, 2017 at 12:25:06PM -0400, Steven Rostedt wrote:
> > On Tue, 4 Jul 2017 15:38:55 +0900
> > Masami Hiramatsu <mhiramat@kernel.org> wrote:
> >
> > > + local testlog=`mktemp $LOG_DIR/${testname}-log.XXXXXX`
> > > + else
> > > + local testlog=`/proc/self/fd/1`
> >
> > cute trick.
>
> Shouldn't this be:
>
> local testlog=/proc/self/fd/1
>
> without the backticks and subshell? We just want to write to the stdout
> file not execute it.
Yeah, it was my mistake...
Thank you!
>
> Or am missing something.
>
> -Stafford
--
Masami Hiramatsu <mhiramat@kernel.org>
prev parent reply other threads:[~2017-07-07 0:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-04 6:34 [PATCH 0/4] selftests: ftrace: ftracetest improvements Masami Hiramatsu
2017-07-04 6:35 ` [PATCH 1/4] selftests: ftrace: Do not failure if there is unsupported tests Masami Hiramatsu
2017-07-04 6:36 ` [PATCH 2/4] selftests: ftrace: Add --fail-unsupported option Masami Hiramatsu
2017-07-04 6:37 ` [PATCH 3/4] selftests: ftrace: Add more verbosity for immediate log Masami Hiramatsu
2017-07-04 6:38 ` [PATCH 4/4] selftests: ftrace: Output only to console with "--logdir -" Masami Hiramatsu
2017-07-05 16:25 ` Steven Rostedt
2017-07-05 16:29 ` Steven Rostedt
2017-07-06 6:00 ` Masami Hiramatsu
2017-07-06 13:06 ` Stafford Horne
2017-07-06 13:18 ` Steven Rostedt
2017-07-07 0:43 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170707094339.49d57164003f662162dad9cf@kernel.org \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=naresh.kamboju@linaro.org \
--cc=rostedt@goodmis.org \
--cc=shorne@gmail.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome