From: Steven Rostedt <rostedt@goodmis.org>
To: Federico Vaga <federico.vaga@vaga.pv.it>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] trace-cmd: replace show_file() -> show_instance_file()
Date: Thu, 6 Jul 2017 18:29:35 -0400 [thread overview]
Message-ID: <20170706182935.7a72ed14@gandalf.local.home> (raw)
In-Reply-To: <20170605093118.29962-3-federico.vaga@vaga.pv.it>
On Mon, 5 Jun 2017 11:31:18 +0200
Federico Vaga <federico.vaga@vaga.pv.it> wrote:
> show_file(name) and show_instance_file(&top_instance, name) are
> equivalent.
>
> Remove the show_file() function in order to have a single function for
> this task.
Actually I find nothing wrong with having a helper function like this.
IIRC, show_file() was first, and then show_instance_file() came later.
There's some files that only exist for the top_instance, and I like the
fact that this is annotated that way.
I'm curious to know what the benefit of removing show_file() is?
-- Steve
>
> Signed-off-by: Federico Vaga <federico.vaga@vaga.pv.it>
> ---
> trace-list.c | 21 ++++++---------------
> trace-local.h | 2 --
> trace-show.c | 18 ++----------------
> trace-snapshot.c | 2 +-
> 4 files changed, 9 insertions(+), 34 deletions(-)
\
next prev parent reply other threads:[~2017-07-06 22:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-05 9:31 Minor Code Clean Up Federico Vaga
2017-06-05 9:31 ` [PATCH 1/2] trace-cmd: use asprintf when possible Federico Vaga
2017-07-06 22:25 ` Steven Rostedt
2017-07-10 0:08 ` Federico Vaga
2017-07-25 14:21 ` Federico Vaga
2017-07-31 19:33 ` Steven Rostedt
2017-07-31 23:12 ` Federico Vaga
2017-06-05 9:31 ` [PATCH 2/2] trace-cmd: replace show_file() -> show_instance_file() Federico Vaga
2017-07-06 22:29 ` Steven Rostedt [this message]
2017-07-10 0:15 ` Federico Vaga
2017-07-31 19:35 ` Steven Rostedt
2017-07-31 23:27 ` Federico Vaga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170706182935.7a72ed14@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=federico.vaga@vaga.pv.it \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®