mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Robert Jarzmik <robert.jarzmik@free.fr>,
	Linus Walleij <linus.walleij@linaro.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	<linux-gpio@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Grygorii Strashko <grygorii.strashko@ti.com>
Subject: [RFC/RFT PATCH 0/3] gpiolib: make gpio irqchip compatible with sparse_irq
Date: Sat, 8 Jul 2017 17:44:10 -0500	[thread overview]
Message-ID: <20170708224413.18281-1-grygorii.strashko@ti.com> (raw)

The idea of this changes was inspired by discussion [1].

Now IRQ mappings are always created for all (allowed) GPIOs in GPIO irqchip in
gpiochip_irqchip_add_key() and this goes against the idea of SPARSE_IRQ and,
as result, leads to:
 - increasing of memory consumption because of allocated IRQ descriptors most
of which will never ever be used (especially on platform with a
high number of GPIOs).
 - imposibility to use GPIO irqchip APIs by gpio drivers when HW implements
GPIO IRQ functionality as IRQ crossbar/multiplexer which has only limited
number of IRQ outputs (example from [1], all GPIOs can be mapped on only 8
IRQs).

Hence, remove static IRQ mapping code from gpiochip_irqchip_add_key() and
instead replace irq_find_mapping() with irq_create_mapping() in
gpiochip_to_irq(). Also add additional gpiochip_irqchip_irq_valid() calls
in gpiochip_to_irq() and gpiochip_irq_map().

After this change gpio2irq mapping will happen the following way when GPIO
irqchip APIs are used by gpio driver:
 - IRQ mappings will be created statically if driver passes first_irq>0
vlaue in gpiochip_irqchip_add_key().
 - IRQ mappings will be created dynamically from gpio_to_irq() or
of_irq_get().

Tested on am335x-evm and dra72-evm-revc.
- dra72-evm-revc: number of created irq mappings decreased from 402 -> 135
- am335x-evm: number of created irq mappings decreased from 188 -> 63

It's good to have more testing feedbacks for these patches 
(personally I do not expect regressions, but who knows). One possible side 
effect is "Cannot allocate irq_descs @ IRQ%d, assuming pre-allocated\n" message
during boot, but in this case it might be good to take a look on such GPIO
drivers to understand why they need to allocate IRQ descriptors.

[1] https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1435847.html

Grygorii Strashko (3):
  gpio: tegra: remove gpio_to_irq() from hw irq handlers
  gpio: pxa: remove gpio_to_irq() from hw irq handlers
  gpiolib: make gpio irqchip compatible with sparse_irq

 drivers/gpio/gpio-pxa.c     |  8 +++++---
 drivers/gpio/gpio-tegra.c   |  3 ++-
 drivers/gpio/gpiolib.c      | 29 ++++++-----------------------
 include/linux/gpio/driver.h |  1 -
 4 files changed, 13 insertions(+), 28 deletions(-)

-- 
2.10.1

             reply	other threads:[~2017-07-08 22:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-08 22:44 Grygorii Strashko [this message]
2017-07-08 22:44 ` [RFC/RFT PATCH 1/3] gpio: tegra: remove gpio_to_irq() from hw irq handlers Grygorii Strashko
2017-08-01  7:49   ` Linus Walleij
2017-07-08 22:44 ` [RFC/RFT PATCH 2/3] gpio: pxa: " Grygorii Strashko
2017-08-01  7:47   ` Linus Walleij
2017-08-01 18:41     ` Robert Jarzmik
2017-07-08 22:44 ` [RFC/RFT PATCH 3/3] gpiolib: make gpio irqchip compatible with sparse_irq Grygorii Strashko
2017-08-01  7:46   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170708224413.18281-1-grygorii.strashko@ti.com \
    --to=grygorii.strashko@ti.com \
    --cc=jbrunet@baylibre.com \
    --cc=jonathanh@nvidia.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=robert.jarzmik@free.fr \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®