mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Robert Jarzmik <robert.jarzmik@free.fr>,
	Linus Walleij <linus.walleij@linaro.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	<linux-gpio@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Grygorii Strashko <grygorii.strashko@ti.com>
Subject: [RFC/RFT PATCH 1/3] gpio: tegra: remove gpio_to_irq() from hw irq handlers
Date: Sat, 8 Jul 2017 17:44:11 -0500	[thread overview]
Message-ID: <20170708224413.18281-2-grygorii.strashko@ti.com> (raw)
In-Reply-To: <20170708224413.18281-1-grygorii.strashko@ti.com>

gpio_to_irq() API expected to be used by GPIO consumers and
not drivers and there are no guarantee that its gpiolib implementation
is irq safe.

Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
 drivers/gpio/gpio-tegra.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
index 88529d3..31b9a86 100644
--- a/drivers/gpio/gpio-tegra.c
+++ b/drivers/gpio/gpio-tegra.c
@@ -389,7 +389,8 @@ static void tegra_gpio_irq_handler(struct irq_desc *desc)
 				chained_irq_exit(chip, desc);
 			}
 
-			generic_handle_irq(gpio_to_irq(gpio + pin));
+			generic_handle_irq(irq_find_mapping(tgi->irq_domain,
+							    gpio + pin));
 		}
 	}
 
-- 
2.10.1

  reply	other threads:[~2017-07-08 22:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-08 22:44 [RFC/RFT PATCH 0/3] gpiolib: make gpio irqchip compatible with sparse_irq Grygorii Strashko
2017-07-08 22:44 ` Grygorii Strashko [this message]
2017-08-01  7:49   ` [RFC/RFT PATCH 1/3] gpio: tegra: remove gpio_to_irq() from hw irq handlers Linus Walleij
2017-07-08 22:44 ` [RFC/RFT PATCH 2/3] gpio: pxa: " Grygorii Strashko
2017-08-01  7:47   ` Linus Walleij
2017-08-01 18:41     ` Robert Jarzmik
2017-07-08 22:44 ` [RFC/RFT PATCH 3/3] gpiolib: make gpio irqchip compatible with sparse_irq Grygorii Strashko
2017-08-01  7:46   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170708224413.18281-2-grygorii.strashko@ti.com \
    --to=grygorii.strashko@ti.com \
    --cc=jbrunet@baylibre.com \
    --cc=jonathanh@nvidia.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=robert.jarzmik@free.fr \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®